[ Device Lab ] Fix wakefulness check to only match log entries with string values

[bkonyi]

Sometimes there can be multiple wakefulness log entries (e.g., 'mWakefulness=Awake' and 'mWakefulness=1'), but we only care about the entry with a string value.

Fixed #174948

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[bkonyi]

This fixes the flaky failures currently making the tree red (example).

[gemini-code-assist]

Code Review

This pull request updates the regular expression used to check the device's wakefulness state to specifically match string values, ignoring numeric ones. My review suggests a further refinement to the regular expression to improve its robustness and efficiency by removing a redundant part, ensuring a non-empty value is matched, and using a non-capturing group.

[flutter-dashboard]

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

[flutter-dashboard]

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

[gaaclarke]

Can we get a test for this?

[gaaclarke]

nit: we should use capture groups instead of doing string manipulation on the result

[bkonyi]

I'm stepping out for a bit, so let's let this land to unblock the tree and I can follow up with the suggested changes. We do have tests verifying the regex matches correctly, so the expression itself is tested. I'll add a negative test to ensure we don't accidentally match `mWakefulness=1`.

…

On Thu, Sep 4, 2025, 1:11 p.m. gaaclarke ***@***.***> wrote: ***@***.**** requested changes on this pull request. Can we get a test for this? ------------------------------ In dev/devicelab/lib/framework/devices.dart <#174953 (comment)>: > @@ -685,7 +685,7 @@ class AndroidDevice extends Device { final String powerInfo = await shellEval('dumpsys', <String>['power']); // A motoG4 phone returns `mWakefulness=Awake`. // A Samsung phone returns `getWakefullnessLocked()=Awake`. - final RegExp wakefulnessRegexp = RegExp(r'.*(mWakefulness=|getWakefulnessLocked\(\)=).*'); + final RegExp wakefulnessRegexp = RegExp(r'(?:mWakefulness|getWakefulnessLocked\(\))=[a-zA-Z]+'); final String wakefulness = grep(wakefulnessRegexp, from: powerInfo).single.split('=')[1].trim(); nit: we should use capture groups instead of doing string manipulation on the result — Reply to this email directly, view it on GitHub <#174953 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFYWZYHV5MAI2QWKRR62NML3RBXFZAVCNFSM6AAAAACFUTG6I6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCOBWGI3TKNBUGI> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>