Remove WindowingOwner.hasTopLevelWindows #178033
Merged
+1
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function doesn't seem to serve any purpose. Top level is not a term we are currently using in the multi window code. If we want to track if we have open windows, this can be done in the Flutter framework - it doesn't need to be done at the platform level.
github-actions
bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the WindowingOwner.hasTopLevelWindows function, which is no longer needed. The changes are applied consistently across the C++ engine, the Dart framework, and related tests. The removal is clean and aligns with the goal of simplifying the multi-windowing code. I've identified one test case that appears to have been removed unintentionally and have suggested its restoration to maintain test coverage.
Contributor
Author
|
Perhaps this function was pre-FFI where you needed to get this information from native code? If the purpose is to track windows created in native code and not in the Dart platform then this should be |
mattkae
approved these changes
Nov 6, 2025
Contributor
mattkae
left a comment
mattkae
left a comment
There was a problem hiding this comment.
Agreed! Just need to fix CI
robert-ancell
added
the
autosubmit
flutter-dashboard
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 6, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 6, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 6, 2025
flutter/flutter@e5d5c01...c5e809a 2025-11-06 robert.ancell@canonical.com Remove WindowingOwner.hasTopLevelWindows (flutter/flutter#178033) 2025-11-06 bruno.leroux@gmail.com Fix DropdownMenu escape key does not close the menu (flutter/flutter#178002) 2025-11-06 pateltirth454@gmail.com Update documentation tool reference in image.dart (flutter/flutter#177782) 2025-11-06 engine-flutter-autoroll@skia.org Roll Skia from 4eb2383d38f2 to 5c4e1352128f (5 revisions) (flutter/flutter#178094) 2025-11-06 chingjun@google.com Revert "Refactor OverlayPortal semantics (#173005)" (flutter/flutter#178007) 2025-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix verified input test failure in CI (attempt 4) (#178018)" (flutter/flutter#178089) 2025-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[web] Unify Surface code between Skwasm and CanvasKit (#177138)" (flutter/flutter#178085) 2025-11-05 34871572+gmackall@users.noreply.github.com Fix verified input test failure in CI (attempt 4) (flutter/flutter#178018) 2025-11-05 38665793+Jaineel-Mamtora@users.noreply.github.com fix: inconsistent horizontal spacing between hours and mins in time picker for non-english language (flutter/flutter#173706) 2025-11-05 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from mpsxF1gd-jbKNvmpm... to cm88aTLui5yorSGYQ... (flutter/flutter#178074) 2025-11-05 okorohelijah@google.com Fix(ios): Remove arm64 exclusion to support Xcode 26 simulators (flutter/flutter#177065) 2025-11-05 engine-flutter-autoroll@skia.org Roll Skia from 2ff897e9b440 to 4eb2383d38f2 (18 revisions) (flutter/flutter#178070) 2025-11-05 1961493+harryterkelsen@users.noreply.github.com [web] Unify Surface code between Skwasm and CanvasKit (flutter/flutter#177138) 2025-11-05 codefu@google.com Update more missing ninja deps (flutter/flutter#178079) 2025-11-05 codefu@google.com Add ninja / cmake deps to failing tests (flutter/flutter#178054) 2025-11-05 mdebbar@google.com [web] Don't add webparagraph suite to CI (flutter/flutter#177681) 2025-11-05 42980667+srivats22@users.noreply.github.com Fixing broken link in engine readme (flutter/flutter#177987) 2025-11-05 34871572+gmackall@users.noreply.github.com Print reason for adb command failure in verified input test (attempt 3) (flutter/flutter#178005) 2025-11-05 1598289+lukemmtt@users.noreply.github.com Fix `ReorderableList` items jumping when drag direction reverses mid-animation (flutter/flutter#173241) 2025-11-05 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` in `overflow_bar.0.dart` example (flutter/flutter#177813) 2025-11-05 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` in `data_table.1.dart` example (flutter/flutter#177812) 2025-11-05 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` in `switch.1.dart` example (flutter/flutter#177811) 2025-11-04 engine-flutter-autoroll@skia.org Roll Skia from c89b6118266b to 2ff897e9b440 (6 revisions) (flutter/flutter#177999) 2025-11-04 34871572+gmackall@users.noreply.github.com Fix verified input test in CI (attempt 2) (flutter/flutter#177961) 2025-11-04 evanwall@buffalo.edu Replace rendering for solid color circles (both filled and stroked) to use SDFs (flutter/flutter#177482) 2025-11-04 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from vxK5obzfr1X9P2kSh... to mpsxF1gd-jbKNvmpm... (flutter/flutter#177996) 2025-11-04 jason-simmons@users.noreply.github.com Validate that platforms specified in .ci.yaml target names match the platforms defined in the platform_properties section (flutter/flutter#177523) 2025-11-04 engine-flutter-autoroll@skia.org Roll Packages from 1a7075b to 3d926aa (6 revisions) (flutter/flutter#177998) 2025-11-04 sigurdm@google.com Remove dead code from snippet_generator (flutter/flutter#174440) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function doesn't seem to serve any purpose.
Top level is not a term we are currently using in the multi window code. If we want to track if we have open windows, this can be done in the Flutter framework - it doesn't need to be done at the platform level.