Skip to content

Conversation

@AbdeMohlbi
Copy link
Contributor

@AbdeMohlbi AbdeMohlbi commented Nov 15, 2025

switch the order of wrong asserts arguments
use assertNotSame , assertNull and assertSame.
and remove a Todo comment that must have slipped from

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Nov 15, 2025
@AbdeMohlbi AbdeMohlbi changed the title Update FlutterViewTest.java Improve code quality FlutterViewTest.java Nov 15, 2025
@AbdeMohlbi AbdeMohlbi marked this pull request as ready for review November 16, 2025 18:19
@AbdeMohlbi AbdeMohlbi requested a review from a team as a code owner November 16, 2025 18:19
@AbdeMohlbi AbdeMohlbi requested a review from reidbaker November 16, 2025 18:19
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Nov 17, 2025
Merged via the queue into flutter:master with commit 1bbcee2 Nov 17, 2025
184 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 17, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 17, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 18, 2025
…#10455)

Manual roll Flutter from 9b5ad8031646 to cc14ef529014 (143 revisions)

Manual roll requested by tarrinneal@google.com

flutter/flutter@9b5ad80...cc14ef5

2025-11-17 bkonyi@google.com [ Widget Preview ] Fix crash when `widget_preview_scaffold/.dart_tool` doesn't exist (flutter/flutter#178662)
2025-11-17 william.oprandi@gmail.com Dev proxy correctly copy query parameters from original request (flutter/flutter#178162)
2025-11-17 engine-flutter-autoroll@skia.org Roll Dart SDK from ac5942fe75d0 to cf94632d94a1 (1 revision) (flutter/flutter#178664)
2025-11-17 116356835+AbdeMohlbi@users.noreply.github.com Improve code quality `FlutterViewTest.java`  (flutter/flutter#178594)
2025-11-17 katelovett@google.com Roll customer tests (flutter/flutter#178652)
2025-11-17 42980667+srivats22@users.noreply.github.com Corrects invalid Flutter wiki links (flutter/flutter#178158)
2025-11-17 sokolovskyi.konstantin@gmail.com Fix LateInitializationError in didChangeTextScaleFactor code example. (flutter/flutter#178375)
2025-11-17 engine-flutter-autoroll@skia.org Roll Skia from d877de9fc23e to 84c83c0dfb4a (3 revisions) (flutter/flutter#178653)
2025-11-17 116356835+AbdeMohlbi@users.noreply.github.com Small refactor in `DartMessenger.java` to use method reference (flutter/flutter#178584)
2025-11-17 116356835+AbdeMohlbi@users.noreply.github.com fix typos in `PlatformChannel.java‎` docs (flutter/flutter#178589)
2025-11-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enable UIScene Migration and update create templates (#178328)" (flutter/flutter#178665)
2025-11-17 116356835+AbdeMohlbi@users.noreply.github.com Remove unnecessary `String.valueOf` in `‎ListenableEditingState.java‎` (flutter/flutter#178597)
2025-11-17 116356835+AbdeMohlbi@users.noreply.github.com Update `Metadata.java‎` to use `getBytes` in a static context (flutter/flutter#178587)
2025-11-17 jason-simmons@users.noreply.github.com Reduce the data copying in CanvasPath related to the SkPathBuilder API migration (flutter/flutter#178512)
2025-11-17 engine-flutter-autoroll@skia.org Roll Packages from 799b62c to ce44ebb (10 revisions) (flutter/flutter#178649)
2025-11-17 15619084+vashworth@users.noreply.github.com Enable UIScene Migration and update create templates (flutter/flutter#178328)
2025-11-17 engine-flutter-autoroll@skia.org Roll Skia from 5fb44352b232 to d877de9fc23e (1 revision) (flutter/flutter#178647)
2025-11-17 15619084+vashworth@users.noreply.github.com Revert "Separate copying dsym into its own target (#178261)" (flutter/flutter#178545)
2025-11-17 mdebbar@google.com [web] Reduce Skwasm test shards to 2 (flutter/flutter#178239)
2025-11-17 engine-flutter-autoroll@skia.org Roll Dart SDK from ee793f732959 to ac5942fe75d0 (1 revision) (flutter/flutter#178637)
2025-11-17 engine-flutter-autoroll@skia.org Roll Skia from b30859d35b89 to 5fb44352b232 (1 revision) (flutter/flutter#178636)
2025-11-17 engine-flutter-autoroll@skia.org Roll Skia from 5b7f8f61528e to b30859d35b89 (1 revision) (flutter/flutter#178634)
2025-11-17 engine-flutter-autoroll@skia.org Roll Skia from aad0515710a9 to 5b7f8f61528e (7 revisions) (flutter/flutter#178631)
2025-11-17 engine-flutter-autoroll@skia.org Roll Skia from 761e1fe67e15 to aad0515710a9 (1 revision) (flutter/flutter#178624)
2025-11-16 engine-flutter-autoroll@skia.org Roll Skia from 5f9157717150 to 761e1fe67e15 (1 revision) (flutter/flutter#178614)
2025-11-16 engine-flutter-autoroll@skia.org Roll Skia from 1b435b65e754 to 5f9157717150 (1 revision) (flutter/flutter#178612)
2025-11-16 engine-flutter-autoroll@skia.org Roll Dart SDK from dffc5f3f9be6 to ee793f732959 (1 revision) (flutter/flutter#178607)
2025-11-16 engine-flutter-autoroll@skia.org Roll Skia from ce2168cf2b6c to 1b435b65e754 (1 revision) (flutter/flutter#178604)
2025-11-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 50eca21d80c4 to dffc5f3f9be6 (1 revision) (flutter/flutter#178603)
2025-11-15 matej.knopp@gmail.com [macOS] Implement dialog window (flutter/flutter#176893)
2025-11-15 engine-flutter-autoroll@skia.org Roll Dart SDK from f6f88ed5e5a1 to 50eca21d80c4 (1 revision) (flutter/flutter#178599)
2025-11-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 9eda5b525ca9 to f6f88ed5e5a1 (1 revision) (flutter/flutter#178576)
2025-11-15 engine-flutter-autoroll@skia.org Roll Skia from c5c3399b3a84 to ce2168cf2b6c (1 revision) (flutter/flutter#178577)
2025-11-15 bernaferrari2@gmail.com Add a `RepeatingAnimationBuilder` API (flutter/flutter#174014)
2025-11-15 engine-flutter-autoroll@skia.org Roll Dart SDK from 486be9c17488 to 9eda5b525ca9 (1 revision) (flutter/flutter#178562)
2025-11-15 engine-flutter-autoroll@skia.org Roll Skia from f5d29842bf45 to c5c3399b3a84 (1 revision) (flutter/flutter#178559)
2025-11-14 engine-flutter-autoroll@skia.org Roll Skia from f58b1b8052a2 to f5d29842bf45 (3 revisions) (flutter/flutter#178556)
2025-11-14 engine-flutter-autoroll@skia.org Roll Dart SDK from c6c5f6c169a9 to 486be9c17488 (1 revision) (flutter/flutter#178555)
2025-11-14 bkonyi@google.com [ Widget Preview ] Gracefully handle unexpected analysis context disposal (flutter/flutter#178550)
2025-11-14 codefu@google.com docs: Add documentation for running devicelab tests in a PR (flutter/flutter#178554)
2025-11-14 matt.boetger@gmail.com [Reland] Generate new Gradle lockfiles and delete ignore files (flutter/flutter#178553)
2025-11-14 flar@google.com Fix crash when doing a SaveLayer under a non-invertible transform (flutter/flutter#178507)
2025-11-14 matt.boetger@gmail.com [Reland] Generate ignore lockfiles and Update Android Embedder Dependencies (flutter/flutter#178538)
2025-11-14 engine-flutter-autoroll@skia.org Roll Skia from 4c02d9fc79c1 to f58b1b8052a2 (1 revision) (flutter/flutter#178543)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine flutter/engine related. See also e: labels. platform-android Android applications specifically team-android Owned by Android platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants