Skip to content

[WIP] Update samples deps and platform dirs#124

Merged
domesticmouse merged 19 commits intoflutter:mainfrom
filiph:chore/update-samples-deps-and-platform-dirs
Jun 17, 2025
Merged

[WIP] Update samples deps and platform dirs#124
domesticmouse merged 19 commits intoflutter:mainfrom
filiph:chore/update-samples-deps-and-platform-dirs

Conversation

@filiph
Copy link
Contributor

@filiph filiph commented Jun 13, 2025

This should bring all templates and samples to the current Flutter & Dart stable.

Flutter 3.32.4 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 6fba2447e9 (6 hours ago) • 2025-06-12 19:03:56 -0700
Engine • revision 8cd19e509d (9 hours ago) • 2025-06-12 16:30:12 -0700
Tools • Dart 3.8.1 • DevTools 2.45.1

The process:

  • for each sample and template
    • edit pubspec.yaml to read sdk: ^3.8.0
    • flutter pub upgrade --major-versions
    • rm -rf ios android web windows macos linux && flutter create . --platforms android,ios,web,windows,macos,linux (except only use the platforms that the given sample uses)
      • may need to use --project-name xyz if the directory doesn't match the name
    • dart run flutter_launcher_icons (if used by the sample)
    • go through all changes and verify that nothing is lost
    • try building sample for various platforms and verify it runs
    • run tests
    • dart format .

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@filiph filiph changed the title [WIP] chore: update samples deps and platform dirs Update samples deps and platform dirs for the basic template Jun 13, 2025
@filiph
Copy link
Contributor Author

filiph commented Jun 13, 2025

Oh, I see, the CI fails before it even starts with:

subosito/flutter-action@395322a6cded4e9ed503aebd4cc1965625f8e59a is not allowed to be used in flutter/games. Actions in this workflow must be: within a repository that belongs to your Enterprise account, created by GitHub, verified in the GitHub Marketplace, or matching the following:

At first I thought the CI action doesn't start because I have [WIP] in the title.

I'm guessing the "not allowed" failure is an org issue and I can't really address it myself. (subosito/flutter-action seems to me like a hard requirement for CI/CD of this repo, unless there's another Flutter GH action of course).

I'll keep working on the upgrade in the meantime.

@filiph filiph changed the title Update samples deps and platform dirs for the basic template [WIP] Update samples deps and platform dirs Jun 13, 2025
@filiph
Copy link
Contributor Author

filiph commented Jun 13, 2025

Ok, @domesticmouse, I think I've migrated everything (except samples/ads, which is in #118 and I can get to it next).

Let me know if I can do anything about the subosito/flutter-action failure.

@domesticmouse
Copy link
Contributor

Let me know if I can do anything about the subosito/flutter-action failure.

We are working on it, promise.

@domesticmouse domesticmouse merged commit 7c64893 into flutter:main Jun 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants