Move Chat widgets to facade and rename. #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors chat widgets by moving them to a facade directory and renaming them with a View suffix. The changes are consistent and well-executed. I have one comment regarding adherence to the repository's contribution guidelines.
Comment on lines
19
to
+23
| export 'src/development_utilities/catalog_view.dart'; | ||
| export 'src/facade/direct_call_integration/model.dart'; | ||
| export 'src/facade/direct_call_integration/utils.dart'; | ||
| export 'src/facade/gen_ui_conversation.dart'; | ||
| export 'src/facade/widgets/chat_primitives.dart'; |
Contributor
There was a problem hiding this comment.
While the code changes are correct, the pull request description is empty. The repository's style guide requires that pull request descriptions include the Pre-Review Checklist from the template. Please update the PR description to adhere to the contribution guidelines.
References
- PR descriptions should include the Pre-Review Checklist from the PR template, with all of the steps completed. (link)
polina-c
added a commit
to polina-c/genui
that referenced
this pull request
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat widgets do not belong to core, as they are high level and opinionated about too many things.