Skip to content

Conversation

@ditman
Copy link
Member

@ditman ditman commented Jan 21, 2026

Description

Added some dart documentation and an example directory to improve package:genui pub score.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@ditman ditman changed the title Hunterino main Improve package:genui pub score. Jan 21, 2026
@ditman
Copy link
Member Author

ditman commented Jan 21, 2026

Apologies @hunterino, I didn't have permissions to push to your original PR, so I had to create a new one. I'm doing this to preserve the authorship of your commits as much as possible!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the project's documentation and developer experience by adding a comprehensive set of examples and extensive Dart documentation for various classes and methods. The new examples directory and its detailed README.md are excellent additions. My review includes a couple of suggestions to enhance the clarity of the changelog and the safety of the setup instructions in the example's README.

@ditman ditman requested a review from jacobsimionato January 21, 2026 22:57
@ditman ditman requested a review from jacobsimionato January 29, 2026 01:09
@ditman
Copy link
Member Author

ditman commented Jan 29, 2026

PTAL @jacobsimionato, I moved content from the big examples/README.md to each separate app, and left the global one as the index.

So after this lands, pub.dev for package:genui will render a README that tells you to find the actual README in the examples directory from the repo, and that one will point you to each specific example.

I'd love the one from pub to just be the same as the one in examples (but I don't want to mess with symlinks, which I'm not sure would work!)

Copy link
Collaborator

@jacobsimionato jacobsimionato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@ditman ditman merged commit 6d0f709 into flutter:main Jan 29, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get Points to 160/160 up 10 points from present

4 participants