Skip to content

Fix flutter action version#817

Merged
andrewkolos merged 3 commits intoflutter:mainfrom
andrewkolos:fix-flutter-action-version
Mar 20, 2026
Merged

Fix flutter action version#817
andrewkolos merged 3 commits intoflutter:mainfrom
andrewkolos:fix-flutter-action-version

Conversation

@andrewkolos
Copy link
Copy Markdown
Collaborator

@andrewkolos andrewkolos commented Mar 19, 2026

Fixes #816.

We could prevent this from happening again by either 1) modifying the org's allow-list to use a wild card for the version if we deem that safe enough or 2) operate like flutter/flutter and instead of using subosito/flutter-action, we just checkout flutter as part of the CI process.

In the meantime, I added code comments that the PR review bot will hopefully pick up on and caution anyone else from making my same mistake.

@andrewkolos andrewkolos marked this pull request as ready for review March 19, 2026 23:57
@andrewkolos andrewkolos merged commit 938a49d into flutter:main Mar 20, 2026
28 checks passed
@andrewkolos
Copy link
Copy Markdown
Collaborator Author

In the meantime, I added code comments that the PR review bot will hopefully pick up on and caution anyone else from making my same mistake.

The review bot doesn't run on this PRs, so this won't work. Anyway, I'll probably file a tech debt issue and me or someone else can re-evaluate during one of our regularly occurring cleanup weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI checks are no longer running on PRs

2 participants