Export more code in ui_primitives to support Flutter tests.#832
Merged
polina-c merged 59 commits intoflutter:mainfrom Mar 26, 2026
Merged
Export more code in ui_primitives to support Flutter tests.#832polina-c merged 59 commits intoflutter:mainfrom
polina-c merged 59 commits intoflutter:mainfrom
Conversation
Co-authored-by: David Iglesias <ditman@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new ui_primitives package, which appears to be a copy of foundational Flutter code. The review comments highlight several areas that require attention before the package is published. These include updating hardcoded package names from 'flutter' to 'ui_primitives' in assertion checks and stack trace demangling, correcting bug report URLs to point to the flutter/genui repository, and addressing various TODO comments related to internal references, web stack trace parsing, UTF-8 byte length calculation, and placeholder files, as per the TEMP_README.md guidelines.
polina-c
changed the title
jacobsimionato
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #825