Remove boilerplate for restaurant finder example, as it is moving to a2ui, to be closer to the agent.#885
Conversation
polina-c
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily involves the removal of the restaurant_finder project files across multiple platforms. It also includes manual updates to auto-generated configuration files in the simple_chat example, specifically adding the jni plugin to Linux and Windows build scripts and updating the macOS Podfile.lock. Feedback across all review comments correctly points out that these generated files should not be edited manually; instead, any necessary dependencies should be declared in the pubspec.yaml file to ensure consistency and prevent changes from being overwritten by the Flutter tool.
| ) | ||
|
|
||
| list(APPEND FLUTTER_FFI_PLUGIN_LIST | ||
| jni |
There was a problem hiding this comment.
This file is automatically generated by the Flutter tool and should not be modified manually, as indicated by the header on line 2. Manual changes will be lost when the tool is next run. If the jni plugin is a required dependency, it should be declared in the pubspec.yaml file instead of being added here.
| ) | ||
|
|
||
| list(APPEND FLUTTER_FFI_PLUGIN_LIST | ||
| jni |
There was a problem hiding this comment.
This file is automatically generated by the Flutter tool and should not be modified manually. Manual changes will be lost when the tool is next run. If the jni plugin is a required dependency, it should be declared in the pubspec.yaml file instead of being added here.
| @@ -1,21 +1,35 @@ | |||
| PODS: | |||
| - audioplayers_darwin (0.0.1): | |||
There was a problem hiding this comment.
The addition of audioplayers_darwin and video_player_avfoundation to this lock file without corresponding entries in examples/simple_chat/pubspec.yaml suggests that this generated file may have been modified manually or is out of sync with the project's dependency declarations. These dependencies should be managed through pubspec.yaml and updated via the standard pod install command.
2 participants
No description provided.