Improve simple chat and make some cross-repo cleanups. by polina-c · Pull Request #905 · flutter/genui

polina-c · 2026-05-10T03:04:17Z

Contributes to #907
Fixes #808

Simple chat

Factor out agent from transport to improve readability
Rename code elements to match terminology
Inspired by @yjbanov 's recent demo, introduced modes: text-only, basic catalog, custom catalog (default)
Stop using class Conversation
Hard code default initial user message to enable faster demos

Cross-repo cleanups

Fix integration tests and add them to CI
Rename 'eval' to 'e2e'
Rename getApiKey to apiKey, because 'get' prefix in methods is dart antipattern
Add BasicCatalogItems.asNoAssetCatalog, that excludes items that require assets (audio, video, images)

Video

Screen.Recording.2026-05-11.at.3.26.19.PM.mov

polina-c · 2026-05-11T14:42:35Z

/gemini review

gemini-code-assist

Code Review

This pull request refactors the simple_chat example to support multiple application modes—text-only, basic catalog, and a custom climbing location catalog—while introducing a new e2e test suite. It also updates the macOS build configuration to use the FlutterGeneratedPluginSwiftPackage and improves error handling in the audio_player widget. Feedback includes correcting a likely typo in the Gemini model name, removing a redundant system prompt fragment, adjusting the logging severity for surface removal, and refining the text controller reset logic to preserve user input.

ditman

Some small comments. Nothing blocking. My biggest concern is exposing the "no asset" version of the basic catalog through its API (it's hard to remove later, and it's something that apps can do very easily themselves when they need it)

ditman · 2026-05-12T20:00:23Z

 - [ ] I read the [Contributors Guide].
 - [ ] I have added sample code updates to the [changelog].
 - [ ] I updated/added relevant documentation (doc comments with `///`).
+- [ ] If my PR is a fork PR, I've checked that [e2e tests] passed.


Can tests be run by end users? We have this same message in google/A2UI, and it's not super relevant unless flutter code is being touched (?)

In a2ui it is relevant if python code is touched, because service is in python.
We have all kinds of dependencies, and we may add more e2e tests. Added condition for changed code. Thank you!

ditman · 2026-05-12T20:03:53Z

 String? debugApiKey;

-String getApiKey() {
+String apiKey() {


Why this renaming? Shouldn't a function name contain a verb?

See https://dart.dev/effective-dart/design#avoid-starting-a-method-name-with-get

ditman · 2026-05-12T20:14:31Z

-  await tester.pumpAndSettle();
+  // We can't use pumpAndSettle() because some catalog widgets (e.g. Image's
+  // loadingBuilder shows a CircularProgressIndicator) have indeterminate
+  // animations that never settle.


Do they never settle because the network is not available, or because the image that we're attempting to load has a bad URL?

CircularProgressIndicator messes up somehow with pumpAndSettle. This fix is suggested by agent. Updated comment. I do not know details and i do not feel it is worth to spend time investigation.

ditman · 2026-05-12T20:21:20Z

+
+When user asks about climbing locations, never use other components.
+''',
+    ..._basicCatalog.systemPromptFragments,


should the default systemprompts be placed before the custom catalog fragments?

Not sure. The example works this way well, and it may break if i change the prompt. Leaving it as is.

ditman · 2026-05-12T20:24:51Z

+
+## Video
+
+https://github.com/user-attachments/assets/469fb2cf-09cf-463c-8c9c-b9c0cb39203b


This demo looks super good. Kudos!

ditman · 2026-05-12T20:27:37Z

+  /// Creates a basic catalog without items that require assets.
+  ///
+  /// This is useful for the app, that do not work with images, audio or video.
+  static Catalog asNoAssetCatalog({
+    List<String> systemPromptFragments = const [],
+  }) => asCatalog(
+    systemPromptFragments: systemPromptFragments,
+  ).copyWithout(itemsToRemove: [audioPlayer, image, video]);
+
+  /// Creates a catalog containing all basic catalog items.


Not a fan of exposing an uglier version of the catalog. I think this should be added by the application itself, rather than our API.

Asset related catalog items require addisional configuration of assets. They cannot be just plugged in. So, it results in extra troubleshooting for early adopters.

Added more comments to both methods to make it clear. Thank you!

polina-c added 8 commits May 9, 2026 18:24

-

12aec58

Update launch.json

1385e65

-

e191423

Update main.dart

383d8cd

-

061855d

-

5f8bd7a

-

ec14b30

-

17a32e8

This comment was marked as outdated.

Sign in to view

polina-c added 21 commits May 9, 2026 20:11

-

abd9f53

-

6574623

Update chat_session.dart

7c3154c

-

df345a3

Update chat_session.dart

5306e15

Update chat_session.dart

f3f687e

Update chat_session.dart

c13922f

-

636e9f5

-

ecd9100

-

39168cf

-

fbbe38c

Update a2ui_transport.dart

b77eda9

-

fd879eb

-

3a1da97

-

303855a

Update chat_session.dart

5750ffe

-

2b49592

-

af3b985

-

2808b02

-

61e43af

Update main.dart

3a9dd82

polina-c added 5 commits May 10, 2026 16:52

-

c396dd0

-

80d0f4c

Update README.md

d9b39b6

-

291ce2b

Update audio_player.dart

8804106

polina-c marked this pull request as ready for review May 11, 2026 00:35

polina-c requested a review from ditman May 11, 2026 00:35

polina-c changed the title ~~Improve simple chat and some cross-repor cleanups.~~ Improve simple chat and make some cross-repo cleanups. May 11, 2026

polina-c added 2 commits May 10, 2026 19:29

-

8406795

-

c5d0d49

polina-c mentioned this pull request May 11, 2026

Retire class Conversation. #908

Open

gemini-code-assist Bot reviewed May 11, 2026

View reviewed changes

Comment thread examples/simple_chat/lib/agent/ai_client.dart

Comment thread examples/simple_chat/lib/chat_session.dart Outdated

Comment thread examples/simple_chat/lib/chat_session.dart Outdated

Comment thread examples/simple_chat/lib/main.dart

polina-c added 10 commits May 11, 2026 12:14

-

5d72a40

Update CONTRIBUTING.md

b50615b

-

602148a

-

72ffa78

-

5f2d9c4

Update chat_session.dart

fabcd72

Update README.md

fb086be

Update chat_session.dart

79a6343

-

1a3cf86

Merge branch 'main' of https://github.com/flutter/genui into sc-plus

50544f9

ditman approved these changes May 12, 2026

View reviewed changes

polina-c added 4 commits May 12, 2026 16:05

-

66ec97d

-

06f039a

Update chat_session.dart

461ab3c

Update basic_catalog.dart

f7f2438

polina-c merged commit 874e292 into flutter:main May 12, 2026
30 checks passed

polina-c deleted the sc-plus branch May 12, 2026 23:39


		## Video

		https://github.com/user-attachments/assets/469fb2cf-09cf-463c-8c9c-b9c0cb39203b

Conversation

polina-c commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Simple chat

Cross-repo cleanups

Video

Uh oh!

This comment was marked as outdated.

Uh oh!

polina-c commented May 11, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

polina-c commented May 10, 2026 •

edited

Loading