Move submodules to repo root.#926
Open
polina-c wants to merge 1 commit into
Open
Conversation
Relocates the a2ui and JSON-Schema-Test-Suite git submodules from inside packages/ to a top-level submodules/ directory so they are not part of any pub package's source tree. This unblocks pub publish --dry-run for genui and json_schema_builder, which was flagging the submodule gitlinks as 'tracked but ignored'. - packages/genui/submodules/a2ui -> submodules/a2ui - packages/json_schema_builder/submodules/JSON-Schema-Test-Suite -> submodules/JSON-Schema-Test-Suite Updates: - .gitmodules paths - analysis_options.yaml exclude pattern - json_schema_builder test fixture paths (now ../../submodules/...) - .agent/skills/genui-helper/SKILL.md references
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to google/A2UI#1383.
Prerequisite for #917
Fix the issue wuth submodules by moving them to root.
ISSUE:
flutter pub publishgives a warning that gitignored files are committed.Pub's gitignore validator reports submodules/a2ui as ignored even though no .gitignore rule actually matches it — git check-ignore returns nothing locally. So pub uses its own logic for this, not real git ignore semantics, and it appears to treat an uninitialized submodule gitlink as "ignored."