Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

For all packages that have not already done so:

  • Ensure that the minimum iOS version is 13.
  • Ensure that the minimum macOS version is 10.15.
  • Ensure that the minimum Flutter SDK version in 3.35 for anything with changes from the above.

In #9849 I did the iOS plugins that had conditional logic for iOS <13, but I forgot to follow up with updating the minimum for the plugins that didn't have conditional logic.

Because this changes min Dart SDKs, it causes autoformat changes. There are no actual code changes in this PR; all Dart file changes are purely the result of re-running dart format.

This does bump the versions, even though repo policy would allow skipping version bumps for only changing min requirements, just to avoid conflating all the changes here with future releases.

Part of flutter/flutter#167735
Part of flutter/flutter#167745

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum supported iOS and macOS versions across several packages to 13 and 10.15, respectively. It also bumps the minimum Flutter SDK to 3.35 and Dart SDK to 3.9 for the modified packages. The changes are primarily in configuration files, with some Dart files being reformatted automatically. The review identifies a minor copy-paste error in one of the changelogs.

@stuartmorgan-g stuartmorgan-g added the triage-ios Should be looked at in iOS triage label Oct 15, 2025
@stuartmorgan-g
Copy link
Collaborator Author

I had to turn off warnings checks for url_launcher_ios for now, since Swift doesn't have an equivalent of using #pragma to suppress a specific warning, and the non-deprecated replacement for using keyWindow in plugins hasn't reached stable yet.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added autosubmit Merge PR when tree becomes green via auto submit App and removed triage-ios Should be looked at in iOS triage labels Oct 17, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 17, 2025
@auto-submit
Copy link
Contributor

auto-submit bot commented Oct 17, 2025

autosubmit label was removed for flutter/packages/10231, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 18, 2025
@auto-submit auto-submit bot merged commit 7ebd635 into flutter:main Oct 18, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 20, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Oct 20, 2025
flutter/packages@3747006...d113bbc

2025-10-20 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump camerax_version from 1.5.0 to 1.5.1 in
/packages/camera/camera_android_camerax/android (flutter/packages#10220)
2025-10-20 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.test.ext:junit-ktx from 1.2.1 to 1.3.0 in
/packages/shared_preferences/shared_preferences_android/android
(flutter/packages#10263)
2025-10-18 engine-flutter-autoroll@skia.org Roll Flutter from
a873a27 to 891d7d5 (32 revisions) (flutter/packages#10257)
2025-10-18 stuartmorgan@google.com [various] Update min iOS/macOS
versions (flutter/packages#10231)
2025-10-17 stuartmorgan@google.com [google_sign_in] Disable flaky web
test (flutter/packages#10249)
2025-10-17 mohellebiabdessalem@gmail.com [various]fix information typo
(flutter/packages#10246)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants