[google_sign_in] Disable flaky web test #10249
Merged
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test is flaking very frequently on WASM. Disabling since it's disrupting the tree, and there hasn't been any progress on investigating the cause of the regression. Tracked in flutter/flutter#176299
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables a flaky web test by adding skip: true. My feedback suggests an improvement to pass the reason for skipping directly to the skip parameter as a string. This is more idiomatic and allows test runners to display the reason, improving clarity.
...ign_in/google_sign_in_web/example/integration_test/flexible_size_html_element_view_test.dart
Outdated
Show resolved
Hide resolved
|
I'm planning on re-running the relevant shard a few times if it passes, to see if we just end up with flake in a different test in this file. |
|
As I suspected, it moved to the next test. I'm guessing I'll need to disable the whole file, but I'll try one at a time to verify. |
tarrinneal
approved these changes
Oct 17, 2025
tarrinneal
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 20, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 20, 2025
flutter/packages@3747006...d113bbc 2025-10-20 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump camerax_version from 1.5.0 to 1.5.1 in /packages/camera/camera_android_camerax/android (flutter/packages#10220) 2025-10-20 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.test.ext:junit-ktx from 1.2.1 to 1.3.0 in /packages/shared_preferences/shared_preferences_android/android (flutter/packages#10263) 2025-10-18 engine-flutter-autoroll@skia.org Roll Flutter from a873a27 to 891d7d5 (32 revisions) (flutter/packages#10257) 2025-10-18 stuartmorgan@google.com [various] Update min iOS/macOS versions (flutter/packages#10231) 2025-10-17 stuartmorgan@google.com [google_sign_in] Disable flaky web test (flutter/packages#10249) 2025-10-17 mohellebiabdessalem@gmail.com [various]fix information typo (flutter/packages#10246) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is flaking very frequently on WASM. Disabling since it's disrupting the tree, and there hasn't been any progress on investigating the cause of the regression.
Tracked in flutter/flutter#176299