Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

For the PRs corresponding to packages where the primary owner is the engine or framework team (per https://github.com/flutter/flutter/blob/master/docs/triage/README.md#labels), auto-add the appropriate triage label to make it easy to run triage queries.

(We intentionally don't do this for the platform triage labels because it's common for platform teams to only need to interact with a PR for part of the PR's lifetime, so the labels are managed manually; that shouldn't be an issue for these package-based filters.)

Also adds a missing auto-label for two_dimensional_scrollables. (There's an issue filed for updating the repo tooling to auto-validate that all packages have auto-label rules.)

For the PRs corresponding to packages where the primary owner is the engine or framework team (per https://github.com/flutter/flutter/blob/master/docs/triage/README.md#labels), auto-add the appropriate triage label to make it easy to run triage queries.

(We intentionally don't do this for the platform triage labels because it's common for platform teams to only need to interact with a PR for part of the PR's lifetime, so the labels are managed manually; that shouldn't be an issue for these package-based filters.)
@stuartmorgan-g stuartmorgan-g requested a review from Piinks October 24, 2025 16:17
@stuartmorgan-g
Copy link
Collaborator Author

Per discussion in flutter/flutter#176841. I went ahead and added engine at the same time since there's no down-side even if it doesn't get used, and I'll let them know it's an option.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/labeler.yml configuration file. It introduces automatic labeling for p: two_dimensional_scrollables when files in its package directory are modified. Additionally, it adds new rules to apply triage-engine and triage-framework labels for changes within a specified list of engine- and framework-related packages, respectively.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2025
@auto-submit auto-submit bot merged commit 169d555 into main Oct 24, 2025
80 checks passed
@auto-submit auto-submit bot deleted the team-triage-auto-labels branch October 24, 2025 22:44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 27, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Oct 27, 2025
flutter/packages@53d6138...bbf96a0

2025-10-27 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.2.20 to 2.2.21
in /packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#10308)
2025-10-27 engine-flutter-autoroll@skia.org Roll Flutter from
cb18290 to 4c91098 (9 revisions) (flutter/packages#10307)
2025-10-26 stuartmorgan@google.com [tool] Add validation of auto-labeler
(flutter/packages#10300)
2025-10-24 stuartmorgan@google.com [ci] Auto-add triage labels for
engine and framework (flutter/packages#10295)
2025-10-24 engine-flutter-autoroll@skia.org Roll Flutter from
75004a6 to cb18290 (48 revisions) (flutter/packages#10299)
2025-10-24 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
9f455d2 to adc9010 (4 revisions) (flutter/packages#10292)
2025-10-24 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers
swift migration - part 2 (flutter/packages#10284)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-zl pushed a commit to flutter/flutter that referenced this pull request Oct 31, 2025
flutter/packages@53d6138...bbf96a0

2025-10-27 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.2.20 to 2.2.21
in /packages/pigeon/platform_tests/test_plugin/android
(flutter/packages#10308)
2025-10-27 engine-flutter-autoroll@skia.org Roll Flutter from
cb18290 to 4c91098 (9 revisions) (flutter/packages#10307)
2025-10-26 stuartmorgan@google.com [tool] Add validation of auto-labeler
(flutter/packages#10300)
2025-10-24 stuartmorgan@google.com [ci] Auto-add triage labels for
engine and framework (flutter/packages#10295)
2025-10-24 engine-flutter-autoroll@skia.org Roll Flutter from
75004a6 to cb18290 (48 revisions) (flutter/packages#10299)
2025-10-24 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
9f455d2 to adc9010 (4 revisions) (flutter/packages#10292)
2025-10-24 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers
swift migration - part 2 (flutter/packages#10284)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants