-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[ci] Auto-add triage labels for engine and framework #10295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For the PRs corresponding to packages where the primary owner is the engine or framework team (per https://github.com/flutter/flutter/blob/master/docs/triage/README.md#labels), auto-add the appropriate triage label to make it easy to run triage queries. (We intentionally don't do this for the platform triage labels because it's common for platform teams to only need to interact with a PR for part of the PR's lifetime, so the labels are managed manually; that shouldn't be an issue for these package-based filters.)
|
Per discussion in flutter/flutter#176841. I went ahead and added engine at the same time since there's no down-side even if it doesn't get used, and I'll let them know it's an option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the .github/labeler.yml configuration file. It introduces automatic labeling for p: two_dimensional_scrollables when files in its package directory are modified. Additionally, it adds new rules to apply triage-engine and triage-framework labels for changes within a specified list of engine- and framework-related packages, respectively.
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
flutter/packages@53d6138...bbf96a0 2025-10-27 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.2.20 to 2.2.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#10308) 2025-10-27 engine-flutter-autoroll@skia.org Roll Flutter from cb18290 to 4c91098 (9 revisions) (flutter/packages#10307) 2025-10-26 stuartmorgan@google.com [tool] Add validation of auto-labeler (flutter/packages#10300) 2025-10-24 stuartmorgan@google.com [ci] Auto-add triage labels for engine and framework (flutter/packages#10295) 2025-10-24 engine-flutter-autoroll@skia.org Roll Flutter from 75004a6 to cb18290 (48 revisions) (flutter/packages#10299) 2025-10-24 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 9f455d2 to adc9010 (4 revisions) (flutter/packages#10292) 2025-10-24 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers swift migration - part 2 (flutter/packages#10284) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@53d6138...bbf96a0 2025-10-27 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.2.20 to 2.2.21 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#10308) 2025-10-27 engine-flutter-autoroll@skia.org Roll Flutter from cb18290 to 4c91098 (9 revisions) (flutter/packages#10307) 2025-10-26 stuartmorgan@google.com [tool] Add validation of auto-labeler (flutter/packages#10300) 2025-10-24 stuartmorgan@google.com [ci] Auto-add triage labels for engine and framework (flutter/packages#10295) 2025-10-24 engine-flutter-autoroll@skia.org Roll Flutter from 75004a6 to cb18290 (48 revisions) (flutter/packages#10299) 2025-10-24 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 9f455d2 to adc9010 (4 revisions) (flutter/packages#10292) 2025-10-24 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers swift migration - part 2 (flutter/packages#10284) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
For the PRs corresponding to packages where the primary owner is the engine or framework team (per https://github.com/flutter/flutter/blob/master/docs/triage/README.md#labels), auto-add the appropriate triage label to make it easy to run triage queries.
(We intentionally don't do this for the platform triage labels because it's common for platform teams to only need to interact with a PR for part of the PR's lifetime, so the labels are managed manually; that shouldn't be an issue for these package-based filters.)
Also adds a missing auto-label for
two_dimensional_scrollables. (There's an issue filed for updating the repo tooling to auto-validate that all packages have auto-label rules.)