Skip to content

[webview_flutter_wkwebview] Fixes crash when running WKNavigationResponse tests on Xcode 26 #10316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −3
Open

[webview_flutter_wkwebview] Fixes crash when running WKNavigationResponse tests on Xcode 26 #10316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e9f772
fix crash
bparrishMines Oct 28, 2025
62a5093
make init private
bparrishMines Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...view_flutter/webview_flutter_wkwebview/darwin/Tests/NavigationDelegateProxyAPITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class NavigationDelegateProxyAPITests: XCTestCase {
let registrar = TestProxyApiRegistrar()
let instance = NavigationDelegateImpl(api: api, registrar: registrar)
let webView = WKWebView(frame: .zero)
let navigationResponse = TestNavigationResponse()
let navigationResponse = TestNavigationResponse.instance

var result: WKNavigationResponsePolicy?
let callbackExpectation = expectation(description: "Wait for callback.")
Expand Down
12 changes: 10 additions & 2 deletions ...view_flutter/webview_flutter_wkwebview/darwin/Tests/NavigationResponseProxyAPITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class NavigationResponseProxyAPITests: XCTestCase {
let registrar = TestProxyApiRegistrar()
let api = registrar.apiDelegate.pigeonApiWKNavigationResponse(registrar)

let instance = WKNavigationResponse()
let instance = TestNavigationResponse.instance
let value = try? api.pigeonDelegate.response(pigeonApi: api, pigeonInstance: instance)

XCTAssertEqual(value, instance.response)
Expand All @@ -22,16 +22,24 @@ class NavigationResponseProxyAPITests: XCTestCase {
let registrar = TestProxyApiRegistrar()
let api = registrar.apiDelegate.pigeonApiWKNavigationResponse(registrar)

let instance = TestNavigationResponse()
let instance = TestNavigationResponse.instance
let value = try? api.pigeonDelegate.isForMainFrame(pigeonApi: api, pigeonInstance: instance)

XCTAssertEqual(value, instance.isForMainFrame)
}
}

class TestNavigationResponse: WKNavigationResponse {
// Provides a static instance to prevent a crash when a WKNavigationResponse is deallocated
// See https://github.com/flutter/flutter/issues/173326
static let instance = TestNavigationResponse()

Comment on lines +35 to +36
Copy link

@gemini-code-assist gemini-code-assist bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To fully enforce the singleton pattern and prevent accidental creation of new TestNavigationResponse instances elsewhere in the tests, it's a good practice to make the initializer private. This will prevent reintroducing the deallocation crash in the future.

  static let instance = TestNavigationResponse()

  private override init() {
    super.init()
  }

let testResponse = URLResponse()

private override init() {
super.init()
}

override var isForMainFrame: Bool {
return true
}
Expand Down