Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

mustache_template was moved into this repository, so is no longer an external dependency that requires an exception.

mustache_template was moved into this repository, so is no longer an external dependency that requires an exception.
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the script/configs/allowed_pinned_deps.yaml file to remove mustache_template from the list of allowed pinned external dependencies. According to the pull request description, this is because the package has been moved into the repository. The change is correct and aligns with this reasoning. I have no further feedback.

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2025
@auto-submit auto-submit bot merged commit 9e59bac into main Nov 14, 2025
80 checks passed
@auto-submit auto-submit bot deleted the mustache-allow-list-removal branch November 14, 2025 20:07
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 17, 2025
flutter/packages@799b62c...ce44ebb

2025-11-17 jessiewong401@gmail.com Kgp bulk update
(flutter/packages#10412)
2025-11-16 robert.odrowaz@leancode.pl [camera_avfoundation] Wrappers
swift migration - part 3 (flutter/packages#10293)
2025-11-15 stuartmorgan@google.com [ci] Update Flutter version for
`release` (flutter/packages#10425)
2025-11-15 engine-flutter-autoroll@skia.org Manual roll Flutter from
c3f2704 to 9b5ad80 (2 revisions) (flutter/packages#10435)
2025-11-14 engine-flutter-autoroll@skia.org Manual roll Flutter from
ee23168 to c3f2704 (5 revisions) (flutter/packages#10433)
2025-11-14 stuartmorgan@google.com [ci] Remove mustache_template from
allowed external deps (flutter/packages#10427)
2025-11-14 adilhanney@disroot.org [animations] Clarify that onClosed is
called before transition (flutter/packages#10400)
2025-11-14 mdebbar@google.com [web_benchmarks] Report correct expected
metrics for wasm (flutter/packages#10236)
2025-11-13 stuartmorgan@google.com [google_maps_flutter] Set properties
before adding maps objects (flutter/packages#10347)
2025-11-13 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
a0e9b9d to b45fa18 (3 revisions) (flutter/packages#10420)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants