[pigeon] Update analyzer range to 8-9 #10466
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the analyzer dependency to support versions 8.x and 9.x. This is a necessary change to keep up with analyzer API updates and involves dropping support for older versions. The code changes correctly migrate from deprecated analyzer APIs to their replacements. The pubspec.yaml and CHANGELOG.md are also updated accordingly.
I have one point of feedback regarding a version constant that seems to have been missed, which should be updated for consistency.
stuartmorgan-g
added
the
autosubmit
flutter/packages@34746bb...8f72e4b 2025-11-19 victoreronmosele@gmail.com [rfw] Update broken links in rfw's README.md (flutter/packages#9796) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.10.1 to 1.11.0 in /packages/image_picker/image_picker_android/android (flutter/packages#10045) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#9855) 2025-11-19 matt.boetger@gmail.com Upgrade AGP to 8.9.1 (flutter/packages#10458) 2025-11-18 stuartmorgan@google.com [pigeon] Update analyzer range to 8-9 (flutter/packages#10466) 2025-11-18 stuartmorgan@google.com [in_app_purchase] Rename Swift Pigeon output file (flutter/packages#10465) 2025-11-18 engine-flutter-autoroll@skia.org Roll Flutter from cc14ef5 to cb7b7df (20 revisions) (flutter/packages#10464) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Updates the compatible
analyzeversions from 6-8 to 8-9. Doing this now will help avoid future compatibility problems like we saw recently with the flutter/flutter Dart roll that was blocked by needing analyzer 8, which Pigeon only very recently supported.This drop 6-7 because it uses replacements for deprecated APIs that were introduced in 8.0, in order to allow 9.0 which removes the deprecated APIs.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3