Skip to content

Conversation

@victoreronmosele
Copy link
Contributor

@victoreronmosele victoreronmosele commented Aug 13, 2025

This PR fixes the broken links in the README.md.

Test exemption reason: PR only affects .md files..

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@github-actions github-actions bot added the p: rfw Remote Flutter Widgets label Aug 13, 2025
@victoreronmosele victoreronmosele marked this pull request as ready for review August 13, 2025 05:25
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several links in README.md that were pointing to old paths and also prepares a new package release by updating pubspec.yaml and CHANGELOG.md. The changes are correct and improve the documentation's accuracy.

For consistency, you might consider updating other links in README.md that still use the old /formats/ path and are being redirected. For example, the links for parseDataFile and parseLibraryFile could also be updated.

@victoreronmosele
Copy link
Contributor Author

victoreronmosele commented Aug 13, 2025

parseDataFile and parseLibraryFile do not need to be updated as they are hidden from the rfw library but exposed through the formats library. So the /formats/ path is correct for them.

See

export 'src/dart/text.dart' hide parseDataFile, parseLibraryFile;
and
export 'src/dart/text.dart';

@stuartmorgan-g stuartmorgan-g self-requested a review August 19, 2025 18:19
@victoreronmosele victoreronmosele force-pushed the update-broken-links-in-readme branch from 21ece5a to 32945b2 Compare August 28, 2025 07:05
@victoreronmosele victoreronmosele force-pushed the update-broken-links-in-readme branch from 32945b2 to bb462ea Compare August 28, 2025 07:10
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 19, 2025
@auto-submit auto-submit bot merged commit 8f72e4b into flutter:main Nov 19, 2025
80 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 19, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 19, 2025
flutter/packages@34746bb...8f72e4b

2025-11-19 victoreronmosele@gmail.com [rfw] Update broken links in rfw's
README.md (flutter/packages#9796)
2025-11-19 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.activity:activity from 1.10.1 to 1.11.0 in
/packages/image_picker/image_picker_android/android
(flutter/packages#10045)
2025-11-19 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in
/packages/url_launcher/url_launcher_android/android
(flutter/packages#9855)
2025-11-19 matt.boetger@gmail.com Upgrade AGP to 8.9.1
(flutter/packages#10458)
2025-11-18 stuartmorgan@google.com [pigeon] Update analyzer range to 8-9
(flutter/packages#10466)
2025-11-18 stuartmorgan@google.com [in_app_purchase] Rename Swift Pigeon
output file (flutter/packages#10465)
2025-11-18 engine-flutter-autoroll@skia.org Roll Flutter from
cc14ef5 to cb7b7df (20 revisions) (flutter/packages#10464)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: rfw Remote Flutter Widgets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants