[go_router_builder] Add analyzer 9 compatibility
#10526
Merged
+65
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
p: go_router_builder
triage-framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates go_router_builder to support version 9 of the analyzer package. The changes primarily involve migrating from the now-removed element2 API to the current element API across the codebase. This includes updating type names (e.g., Element2 to Element), method calls, and property accessors to their modern equivalents. The pubspec.yaml is updated to reflect the new analyzer version constraint (>=8.0.0 <10.0.0), and the CHANGELOG.md is updated accordingly. The changes are correct and consistently applied to achieve compatibility with analyzer v9.
Collaborator
Author
|
test-exempt: code refactor with no semantic change |
This comment was marked as off-topic.
This comment was marked as off-topic.
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 2, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 2, 2025
flutter/packages@c8be05d...148dcd2 2025-12-01 stuartmorgan@google.com [go_router_builder] Require analyzer 8.2 (flutter/packages#10546) 2025-12-01 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/local_auth/local_auth_android/android (flutter/packages#10505) 2025-12-01 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the kotlin-gradle-plugin group across 7 directories with 1 update (flutter/packages#10501) 2025-12-01 stuartmorgan@google.com [google_fonts] Replace deprecated FontWeight.index (flutter/packages#10544) 2025-12-01 antoine.herzog@hey.com [camera_web] Fix camera initialization failure on Firefox Android (flutter/packages#10341) 2025-12-01 engine-flutter-autoroll@skia.org Roll Flutter from 2b5fa94 to 05d6005 (3 revisions) (flutter/packages#10543) 2025-12-01 stuartmorgan@google.com [file_selector] Migrate to UIScene (flutter/packages#10429) 2025-11-30 stuartmorgan@google.com [go_router_builder] Add `analyzer` 9 compatibility (flutter/packages#10526) 2025-11-29 engine-flutter-autoroll@skia.org Roll Flutter from 022b155 to 2b5fa94 (14 revisions) (flutter/packages#10535) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
…r#179343) flutter/packages@c8be05d...148dcd2 2025-12-01 stuartmorgan@google.com [go_router_builder] Require analyzer 8.2 (flutter/packages#10546) 2025-12-01 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/local_auth/local_auth_android/android (flutter/packages#10505) 2025-12-01 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the kotlin-gradle-plugin group across 7 directories with 1 update (flutter/packages#10501) 2025-12-01 stuartmorgan@google.com [google_fonts] Replace deprecated FontWeight.index (flutter/packages#10544) 2025-12-01 antoine.herzog@hey.com [camera_web] Fix camera initialization failure on Firefox Android (flutter/packages#10341) 2025-12-01 engine-flutter-autoroll@skia.org Roll Flutter from 2b5fa94 to 05d6005 (3 revisions) (flutter/packages#10543) 2025-12-01 stuartmorgan@google.com [file_selector] Migrate to UIScene (flutter/packages#10429) 2025-11-30 stuartmorgan@google.com [go_router_builder] Add `analyzer` 9 compatibility (flutter/packages#10526) 2025-11-29 engine-flutter-autoroll@skia.org Roll Flutter from 022b155 to 2b5fa94 (14 revisions) (flutter/packages#10535) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the compatible
analyzerrange from 7.x-8.x to 8.x-9.x (9.0 being the current version). The range has to be moved, rather than expanded, because part of the breaking change in 9.0 was removing methods that were replaced and deprecated in 8.x.Fixes flutter/flutter#179073
Fixes flutter/flutter#166603
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3