[pigeon] Fixes crash that occurs when an object that is removed from the instance manager calls to Dart #10552
+1,291
−746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bparrishMines
changed the title
bparrishMines
changed the title
bparrishMines
commented
Dec 3, 2025
| class ProxyApiDelegate: ProxyApiTestsPigeonProxyApiDelegate { | ||
| func pigeonApiProxyApiTestClass(_ registrar: ProxyApiTestsPigeonProxyApiRegistrar) | ||
| -> PigeonApiProxyApiTestClass | ||
| class ProxyApiTestClassDelegate: PigeonApiDelegateProxyApiTestClass { |
Contributor
Author
There was a problem hiding this comment.
This is just copied and pasted outside of the ProxyApiDelegate.pigeonApiProxyApiTestClass so that the test has access to it.
tarrinneal
approved these changes
Dec 3, 2025
| .failure( | ||
| ${_getErrorClassName(generatorOptions)}( | ||
| code: "missing-instance-error", | ||
| message: "Calling instance is not in the instance manager.", details: ""))) |
Contributor
There was a problem hiding this comment.
Calling instance is not...
Should it be calling instance [instance name]?
Contributor
Author
There was a problem hiding this comment.
[instanceName] would always be pigeonInstanceArg and wouldn't be that helpful. But the error message probably would be more helpful if I added the class and method name here, so I'll add that.
bparrishMines
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event of a hot restart, the native
InstanceManagersare cleared. There is then a chance for a class to make a callback when it is no in the instance manager which leads to a null exception in the codec.Part of fixing flutter/flutter#176451
Pigeon side fix for #10529
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3