-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[google_maps_flutter] Add iOS SDK 10.x support #10720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for Google Maps SDK 10.x by updating the podspec to allow for the new version and adding a new example application that targets iOS 16 to ensure compatibility. The changes are well-organized and clear. My only finding is a minor typo in the CHANGELOG.
packages/google_maps_flutter/google_maps_flutter_ios/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
flutter/packages@d3f860d...9705815 2026-01-07 47866232+chunhtai@users.noreply.github.com [ci] setup flutter in batch release workflow (flutter/packages#10735) 2026-01-07 augustocesarperin@gmail.com [mustache_template] Improve error throwing (flutter/packages#10700) 2026-01-06 47866232+chunhtai@users.noreply.github.com [ci] Adjust workflow for dispatching go_router batch release (flutter/packages#10733) 2026-01-06 116356835+AbdeMohlbi@users.noreply.github.com [rfw] Remove scripting language integration section from `README` (flutter/packages#10726) 2026-01-06 stuartmorgan@google.com [image_picker] Update for UIScene compatibility (flutter/packages#10677) 2026-01-06 stuartmorgan@google.com [google_maps_flutter] Add iOS SDK 10.x support (flutter/packages#10720) 2026-01-06 6655696+guidezpl@users.noreply.github.com Update Google Fonts to v7.0.0 with new and removed fonts (flutter/packages#10713) 2026-01-06 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the kotlin-gradle-plugin group across 7 directories with 1 update (flutter/packages#10661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter/packages@d3f860d...9705815 2026-01-07 47866232+chunhtai@users.noreply.github.com [ci] setup flutter in batch release workflow (flutter/packages#10735) 2026-01-07 augustocesarperin@gmail.com [mustache_template] Improve error throwing (flutter/packages#10700) 2026-01-06 47866232+chunhtai@users.noreply.github.com [ci] Adjust workflow for dispatching go_router batch release (flutter/packages#10733) 2026-01-06 116356835+AbdeMohlbi@users.noreply.github.com [rfw] Remove scripting language integration section from `README` (flutter/packages#10726) 2026-01-06 stuartmorgan@google.com [image_picker] Update for UIScene compatibility (flutter/packages#10677) 2026-01-06 stuartmorgan@google.com [google_maps_flutter] Add iOS SDK 10.x support (flutter/packages#10720) 2026-01-06 6655696+guidezpl@users.noreply.github.com Update Google Fonts to v7.0.0 with new and removed fonts (flutter/packages#10713) 2026-01-06 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump the kotlin-gradle-plugin group across 7 directories with 1 update (flutter/packages#10661) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Adds support for Google Maps SDK 10.x.
The new ios16/ example is just a copy of ios15/ with the min deployment version changed.
Previously I had intended to do this as part of adding SPM support, but separating them allows landing this sooner, and will reduce the complexity of the SPM addition.
Fixes flutter/flutter#180272
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3