-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[google_fonts] Update to v8.0.0 with new and removed fonts #10785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+3,172
−650
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels unfortunate to introduce another breaking release so soon after 7.0.0. Is there any opportunity to not remove the two fonts and keep them around, maybe in a deprecated state for a while?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would lean towards not since it's not worth the additional tech debt. At the same time, we've been adhering to the convention that any font removal results in a major version bump. Also, I've gotten confirmation from the fonts team that they'll generate this quarterly, so we could consider this one exceptionally 2 months early (should land the woff2 update first) how does that sound?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it currently stands on how releases are done for this package and as a user/dev, in my experience, being worried about a major (breaking) release, based on time scale shouldn't even be a factor. It's better to give users the updates ASAP; they can choose to update or not, and at least they'll know about the breaking changes sooner than later to make appropriate adjustments.
I'm also on board that font removals should be a breaking change too. The whole package is about fonts and when one is removed, it could break a project.
A way around it for both the points I mentioned is to change how releases are done. My suggestion would be to add a
@deprecatedannotation for fonts that are to be removed and eventually remove them on a scheduled time interval. Then you can choose when to do a major release.