[google_maps_flutter] Add README section about SDK versions#11005
Conversation
Updates the iOS section of the app-facing package's README to discuss the new `google_maps_flutter_ios_sdk*` packages and how to select between them. Fixes flutter/flutter#146920
There was a problem hiding this comment.
Code Review
This pull request updates documentation for the google_maps_flutter package. The CHANGELOG.md and pubspec.yaml are updated to version 2.14.2. The primary changes are in README.md, where the iOS setup instructions have been revised. The Objective-C example for API key setup is removed, and a new, detailed section is added to explain how to select different Google Maps SDK versions for iOS. This new section covers the default behavior, how to select specific SDK versions, and provides important guidance for package authors. My feedback includes a suggestion to clarify the description of the default SDK selection behavior for improved accuracy.
|
I don't love how verbose this is, but I couldn't see a way to take anything out without removing context that's critical to understanding why this option even exists and how to navigate it. As the CocoaPods->SwiftPM transition progresses we can probably shorten it by assuming SwiftPM and just describing the SDK options, and then having the default implementation part be last as a more legacy discussion. (And eventually, when Flutter requires iOS 16, we can just remove that part entirely.) I'm also not happy about adding more platform-specific docs to the app-facing README, since we are trying to stop doing that, but the new standard practice is to delegate to the platform implementation package README for that, and that would be weird here ("Go read the |
Updates the iOS section of the app-facing package's README to discuss the new
google_maps_flutter_ios_sdk*packages and how to select between them.Also removes the Obj-C part of the delegate update example, since at this point it's extremely unlikely that new developers are using Obj-C, and if they are they are making a deliberate choice to do so and so can be reasonably expected to know how to translate to Obj-C.
Fixes flutter/flutter#146920
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3