[google_sign_in] Simply Kotlin/Java interop utils#11011
[google_sign_in] Simply Kotlin/Java interop utils#11011auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
Replaces one-off wrappers with a templated version. While this isn't important in isolation, it sets a better precedent for us to follow for future plugins, and likely for Pigeon generation of helper utils.
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a good simplification to the Kotlin/Java interoperability helpers. It replaces four specific callback completion functions with a single, more flexible generic function completeWithValue. This change reduces code duplication in ResultUtils.kt and simplifies the native Android implementation. The call sites in GoogleSignInPlugin.java are updated accordingly. The CHANGELOG.md and pubspec.yaml are also updated to reflect this internal improvement.
|
test-exempt: code refactor with no semantic change |
|
This pr looks fine but I dont actually understand why it is better for java/kotlin interop. Is the idea that eventually the completeWithValue would be a more generic utility class? |
If we go the route of having Pigeon generate these helpers for using Kotlin generation in a Java project, then this generic form means we only have to have the generator output that generic helper, instead of a separate helper for every single returned type. |
stuartmorgan-g
added
the
autosubmit
flutter/packages@f83926f...59f905c 2026-02-18 52160996+FMorschel@users.noreply.github.com [camera][google_fonts] Fixes future warning for `await`ing `Future` returns in `async` bodies inside `try` blocks (flutter/packages#11009) 2026-02-18 robert.odrowaz@leancode.pl [camera_avfoundation] Pigeon swift migration - part 2 (flutter/packages#10980) 2026-02-17 8490712+ruicraveiro@users.noreply.github.com [camera_android_camerax] Adds support for video stabilization (flutter/packages#11020) 2026-02-17 nateshmbhat1@gmail.com [video_player] Adds audio track metadata fetching and audio track selection feature (flutter/packages#9925) 2026-02-17 stuartmorgan@google.com [video_player] Update Android to exoplayer 1.9.1 (flutter/packages#10904) 2026-02-17 joonas.kerttula@codemate.com [google_maps_flutter_android] Add advanced markers support (flutter/packages#10381) 2026-02-17 stuartmorgan@google.com [google_maps_flutter] Standardize iOS class and file names (flutter/packages#10964) 2026-02-17 stuartmorgan@google.com [google_sign_in] Simply Kotlin/Java interop utils (flutter/packages#11011) 2026-02-17 engine-flutter-autoroll@skia.org Roll Flutter from 9bda20a to 6e4a481 (103 revisions) (flutter/packages#11041) 2026-02-17 stuartmorgan@google.com [ci] Update repo for 3.41 (flutter/packages#11017) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Replaces one-off wrappers with a templated version. While this isn't important in isolation, it sets a better precedent for us to follow for future plugins, and likely for Pigeon generation of helper utils.
The "Unit" forms of the wrappers are still necessary because there's no way (AFAICT) to cause Java to infer the Unit type, since it's not a thing in Java.
I've validated that the type inference on the generic is still enforcing type safety based on the inferred type. I.e., if I try to pass the wrong value type, it won't compile.
Related to flutter/flutter#158287
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3