Skip to content

[google_maps_flutter] Add color scheme support to web implementation#11279

Merged
auto-submit[bot] merged 33 commits intoflutter:mainfrom
stuartmorgan-g:maps-web-color-scheme-web
Mar 18, 2026
Merged

[google_maps_flutter] Add color scheme support to web implementation#11279
auto-submit[bot] merged 33 commits intoflutter:mainfrom
stuartmorgan-g:maps-web-color-scheme-web

Conversation

@stuartmorgan-g
Copy link
Collaborator

Web portion of #10471, incorporating review feedback and some other minor cleanup.

Part of flutter/flutter#176445

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

martyfuhry and others added 30 commits November 19, 2025 09:31
…map initialization. Adds comments to MapColorScheme enum.
@stuartmorgan-g stuartmorgan-g changed the title Maps web color scheme web [google_maps_flutter] Add color scheme support to web implementation Mar 18, 2026
@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review March 18, 2026 14:23
@stuartmorgan-g stuartmorgan-g requested a review from mdebbar as a code owner March 18, 2026 14:23
@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Mar 18, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds colorScheme support to the web implementation. It updates pubspec.yaml and CHANGELOG.md, and modifies convert.dart to apply the colorScheme to the map options. A review comment has been added suggesting to only apply the colorScheme when a mapId is provided, as the feature is for cloud-based maps.

Comment on lines +134 to +139
final gmaps.ColorScheme? jsColorScheme = _gmapTypeColorSchemeForPluginColor(
configuration.colorScheme,
);
if (jsColorScheme != null) {
options.colorScheme = jsColorScheme;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The colorScheme property should only be applied when a mapId is present, as this feature is for cloud-based maps on the web. Please wrap this logic in a check for configuration.mapId.

Suggested change
final gmaps.ColorScheme? jsColorScheme = _gmapTypeColorSchemeForPluginColor(
configuration.colorScheme,
);
if (jsColorScheme != null) {
options.colorScheme = jsColorScheme;
}
if (configuration.mapId != null) {
final gmaps.ColorScheme? jsColorScheme = _gmapTypeColorSchemeForPluginColor(
configuration.colorScheme,
);
if (jsColorScheme != null) {
options.colorScheme = jsColorScheme;
}
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything in the docs that actually requires a mapId.

@stuartmorgan-g stuartmorgan-g added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Mar 18, 2026
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 18, 2026

autosubmit label was removed for flutter/packages/11279, because - The status or check suite Windows_x64 repo_tools_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2026
@auto-submit auto-submit bot merged commit 3c0cdab into flutter:main Mar 18, 2026
81 checks passed
@stuartmorgan-g stuartmorgan-g deleted the maps-web-color-scheme-web branch March 18, 2026 15:52
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Mar 19, 2026
flutter/packages@afa1a1c...99155a8

2026-03-19 engine-flutter-autoroll@skia.org Roll Flutter from
d117642 to dd64978 (24 revisions) (flutter/packages#11281)
2026-03-18 stuartmorgan@google.com [local_auth] Convert to Kotlin gradle
for the plugin build files (flutter/packages#11169)
2026-03-18 stuartmorgan@google.com [google_maps_flutter] Add color
scheme support to app-facing package (flutter/packages#11280)
2026-03-18 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Updates platform views on iOS to only have a
weak reference to the native view (flutter/packages#11175)
2026-03-18 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.core:core from 1.17.0 to 1.18.0 in
/packages/local_auth/local_auth_android/android (flutter/packages#11256)
2026-03-18 49699333+dependabot[bot]@users.noreply.github.com
[dependabot]: Bump androidx.core:core-ktx from 1.13.0 to 1.18.0 in
/packages/interactive_media_ads/android (flutter/packages#11255)
2026-03-18 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
ff37bef to 2c9eb20 (6 revisions) (flutter/packages#11285)
2026-03-18 stuartmorgan@google.com [google_maps_flutter] Add color
scheme support to web implementation (flutter/packages#11279)
2026-03-18 elitree@gmail.com [google_maps_flutter_android] Batch
clustered marker operations (flutter/packages#10940)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: google_maps_flutter platform-web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants