[google_maps_flutter] Add color scheme support to web implementation#11279
[google_maps_flutter] Add color scheme support to web implementation#11279auto-submit[bot] merged 33 commits intoflutter:mainfrom
Conversation
…map initialization. Adds comments to MapColorScheme enum.
There was a problem hiding this comment.
Code Review
This pull request adds colorScheme support to the web implementation. It updates pubspec.yaml and CHANGELOG.md, and modifies convert.dart to apply the colorScheme to the map options. A review comment has been added suggesting to only apply the colorScheme when a mapId is provided, as the feature is for cloud-based maps.
| final gmaps.ColorScheme? jsColorScheme = _gmapTypeColorSchemeForPluginColor( | ||
| configuration.colorScheme, | ||
| ); | ||
| if (jsColorScheme != null) { | ||
| options.colorScheme = jsColorScheme; | ||
| } |
There was a problem hiding this comment.
The colorScheme property should only be applied when a mapId is present, as this feature is for cloud-based maps on the web. Please wrap this logic in a check for configuration.mapId.
| final gmaps.ColorScheme? jsColorScheme = _gmapTypeColorSchemeForPluginColor( | |
| configuration.colorScheme, | |
| ); | |
| if (jsColorScheme != null) { | |
| options.colorScheme = jsColorScheme; | |
| } | |
| if (configuration.mapId != null) { | |
| final gmaps.ColorScheme? jsColorScheme = _gmapTypeColorSchemeForPluginColor( | |
| configuration.colorScheme, | |
| ); | |
| if (jsColorScheme != null) { | |
| options.colorScheme = jsColorScheme; | |
| } | |
| } |
There was a problem hiding this comment.
I don't see anything in the docs that actually requires a mapId.
|
autosubmit label was removed for flutter/packages/11279, because - The status or check suite Windows_x64 repo_tools_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
flutter/packages@afa1a1c...99155a8 2026-03-19 engine-flutter-autoroll@skia.org Roll Flutter from d117642 to dd64978 (24 revisions) (flutter/packages#11281) 2026-03-18 stuartmorgan@google.com [local_auth] Convert to Kotlin gradle for the plugin build files (flutter/packages#11169) 2026-03-18 stuartmorgan@google.com [google_maps_flutter] Add color scheme support to app-facing package (flutter/packages#11280) 2026-03-18 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Updates platform views on iOS to only have a weak reference to the native view (flutter/packages#11175) 2026-03-18 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.17.0 to 1.18.0 in /packages/local_auth/local_auth_android/android (flutter/packages#11256) 2026-03-18 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core-ktx from 1.13.0 to 1.18.0 in /packages/interactive_media_ads/android (flutter/packages#11255) 2026-03-18 engine-flutter-autoroll@skia.org Roll Flutter (stable) from ff37bef to 2c9eb20 (6 revisions) (flutter/packages#11285) 2026-03-18 stuartmorgan@google.com [google_maps_flutter] Add color scheme support to web implementation (flutter/packages#11279) 2026-03-18 elitree@gmail.com [google_maps_flutter_android] Batch clustered marker operations (flutter/packages#10940) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Web portion of #10471, incorporating review feedback and some other minor cleanup.
Part of flutter/flutter#176445
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2