[two_dimensional_scrollables] Fix span border decorations in flipped cross axes

[Piinks]

Fixes flutter/flutter#177117

Fixes an issue in two_dimensional_scrollables where TableSpan vertical borders were incorrectly flipped when ScrollableDetails.horizontal was reversed.

The SpanBorder.paint method previously used its own axisDirection to determine leading and trailing edge flipping for a cross-axis border component. This works in natural scrolling directions, but creates an inverted orientation assumption when the perpendicular axis is reversed.

Does not affect TreeView, since that widget does not allow for reversed axes.

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

[gemini-code-assist]

Code Review

This pull request fixes an issue where TableSpan borders were flipped when one or both axis directions were reversed. The fix involves introducing a crossAxisDirection parameter to SpanDecorationPaintDetails and updating the SpanBorder.paint method to use this new parameter for accurate border rendering. The RenderTableViewport and RenderTreeViewport classes were updated to pass the appropriate cross-axis direction. A new test case was added to verify the fix for a reversed horizontal axis. The reviewer suggests adding an additional test case for a row span with a reversed vertical axis to improve test coverage.

[AbdeMohlbi]

SGTM, do we need to link to the issue from that test ie: test for issue177777 for example ?

[Piinks]

SGTM, do we need to link to the issue from that test ie: test for issue177777 for example ?

Oh good call! I will add the regression test references, thanks!

[DMouayad]

Thanks 🙏