[vector_graphic] docs: corrected width/height description in VectorGraphic#11361
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Mar 30, 2026
Merged
Conversation
github-actions
bot
added
p: vector_graphics
triage-engine
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the vector_graphics package version to 1.1.21 and refines the documentation for the width and height parameters of the VectorGraphic widget. Feedback suggests further clarifying this documentation to describe behavior in both constrained and unconstrained environments for improved precision.
|
|
||
| /// If specified, the width to use for the vector graphic. If unspecified, | ||
| /// the vector graphic will take the width of its parent. | ||
| /// the vector graphic will take the width of the graphic. |
There was a problem hiding this comment.
This documentation is an improvement for unconstrained scenarios, but it could be more precise about behavior in constrained environments. To avoid ambiguity, it's helpful to mention both cases, similar to how Flutter's Image widget is documented.
Suggested change
| /// the vector graphic will take the width of the graphic. | |
| /// the graphic will be sized to its parent's constraints, or to its | |
| /// intrinsic width if unconstrained. |
|
|
||
| /// If specified, the height to use for the vector graphic. If unspecified, | ||
| /// the vector graphic will take the height of its parent. | ||
| /// the vector graphic will take the height of the graphic. |
There was a problem hiding this comment.
Similar to the width property, this documentation could be more precise by describing the behavior for both constrained and unconstrained environments.
Suggested change
| /// the vector graphic will take the height of the graphic. | |
| /// the graphic will be sized to its parent's constraints, or to its | |
| /// intrinsic height if unconstrained. |
jason-simmons
approved these changes
Mar 30, 2026
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 31, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 31, 2026
flutter/packages@582f0e7...b04f3e5 2026-03-30 jhy03261997@gmail.com [ci] Compares commits before creating a sync PR to sync release branch back to the main branch. (flutter/packages#11398) 2026-03-30 jhy03261997@gmail.com [ci] Add permission to release_from_branches.yml (flutter/packages#11397) 2026-03-30 srawlins@google.com [pigeon] Reduces lint rules ignored in generated Dart code (flutter/packages#11230) 2026-03-30 stuartmorgan@google.com [google_maps_flutter] Add missing exports (flutter/packages#11196) 2026-03-30 89637597+eflat64@users.noreply.github.com [vector_graphic] docs: corrected width/height description in VectorGraphic (flutter/packages#11361) 2026-03-30 47866232+chunhtai@users.noreply.github.com [ci] Uses fluttergithubbot to create branches and PRs (flutter/packages#11368) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected the documentation for width and height parameters in the VectorGraphic widget.
Fixes flutter/flutter#184116
Pre-Review Checklist
[shared_preferences]///).Test exemption: this is a documentation-only change.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2