Skip to content

[various] Convert remaining Groovy files to Kotlin#11443

Merged
auto-submit[bot] merged 9 commits intoflutter:mainfrom
stuartmorgan-g:kotlin-gradle-remaining-examples
Apr 7, 2026
Merged

[various] Convert remaining Groovy files to Kotlin#11443
auto-submit[bot] merged 9 commits intoflutter:mainfrom
stuartmorgan-g:kotlin-gradle-remaining-examples

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

This is the last in the series of PRs to convert all of our legacy Groovy Gradle files to Kotlin. This converts all remaining Groovy files in the repository to Kotlin (with the exception of legacy_project; see flutter/flutter#184656). This is the app-facing plugin example apps, as well as the Pigeon example app, as those were the ones not yet converted.

As with #11421 I did this as an in-place update primarily done via Gemini, rather than by recreating the entire test app, since plugins tend to have special setup/configs in their example apps:

  • I had Gemini mass-convert the remaining files using the previous conversions as a template.
  • I had Gemini specifically re-review the results for any accidental changes.
  • I did some manual checks for unexpected diffs between resulting files.
  • I did a small amount of manual fixup where Gemini didn't convert correctly.
  • I removed settings_aar.gradle from local_auth's example (the only package containing it); it seems to have been something auto-created by an old version of flutter for AndroidX compat during a transition phase, and no longer seems to be relevant.

I also removed all the logic from the repo tool to validate Groovy versions of files, now that we don't need to support them, and simplified/updated the tests accordingly.

Fixes flutter/flutter#176065

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@stuartmorgan-g stuartmorgan-g added CICD Run CI/CD and removed CICD Run CI/CD labels Apr 6, 2026
@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review April 6, 2026 14:45
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates Android example projects across numerous packages from Groovy to Kotlin DSL, replacing build.gradle and settings.gradle files with .kts versions. The gradle-check tool and its test suite are updated to remove Groovy-specific logic, hardcoding validation for Kotlin DSL syntax and file naming conventions. I have no feedback to provide as the review comments were found to be factually incorrect regarding the state of the implementation in the provided diffs.

@stuartmorgan-g stuartmorgan-g added CICD Run CI/CD and removed CICD Run CI/CD labels Apr 6, 2026
@github-actions github-actions bot removed the CICD Run CI/CD label Apr 6, 2026
@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label Apr 6, 2026
@stuartmorgan-g
Copy link
Copy Markdown
Collaborator Author

This is now really ready for review.

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 7, 2026
@auto-submit auto-submit bot merged commit e37fa8f into flutter:main Apr 7, 2026
82 checks passed
@stuartmorgan-g stuartmorgan-g deleted the kotlin-gradle-remaining-examples branch April 7, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[packages] Migrate Gradle files to Kotlin

2 participants