[various] Convert remaining Groovy files to Kotlin#11443
Merged
auto-submit[bot] merged 9 commits intoflutter:mainfrom Apr 7, 2026
Merged
[various] Convert remaining Groovy files to Kotlin#11443auto-submit[bot] merged 9 commits intoflutter:mainfrom
auto-submit[bot] merged 9 commits intoflutter:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request migrates Android example projects across numerous packages from Groovy to Kotlin DSL, replacing build.gradle and settings.gradle files with .kts versions. The gradle-check tool and its test suite are updated to remove Groovy-specific logic, hardcoding validation for Kotlin DSL syntax and file naming conventions. I have no feedback to provide as the review comments were found to be factually incorrect regarding the state of the implementation in the provided diffs.
Collaborator
Author
|
This is now really ready for review. |
reidbaker
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last in the series of PRs to convert all of our legacy Groovy Gradle files to Kotlin. This converts all remaining Groovy files in the repository to Kotlin (with the exception of legacy_project; see flutter/flutter#184656). This is the app-facing plugin example apps, as well as the Pigeon example app, as those were the ones not yet converted.
As with #11421 I did this as an in-place update primarily done via Gemini, rather than by recreating the entire test app, since plugins tend to have special setup/configs in their example apps:
settings_aar.gradlefrom local_auth's example (the only package containing it); it seems to have been something auto-created by an old version offlutterfor AndroidX compat during a transition phase, and no longer seems to be relevant.I also removed all the logic from the repo tool to validate Groovy versions of files, now that we don't need to support them, and simplified/updated the tests accordingly.
Fixes flutter/flutter#176065
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2