[webview_flutter_wkwebview] Tear down ProxyAPIRegistrar in applicationWillTerminate
#11484
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| // Copyright 2013 The Flutter Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| import XCTest | ||
|
|
||
| @testable import webview_flutter_wkwebview | ||
|
|
||
| #if os(iOS) | ||
| import Flutter | ||
| import UIKit | ||
| #endif | ||
|
|
||
| class WebViewFlutterPluginTests: XCTestCase { | ||
| #if os(iOS) | ||
| func testInstanceManagerIsDeallocatedInApplicationWillTerminate() { | ||
| let plugin = WebViewFlutterPlugin(binaryMessenger: TestBinaryMessenger()) | ||
| plugin.proxyApiRegistrar!.setUp() | ||
|
|
||
| let view = UIView() | ||
| _ = plugin.proxyApiRegistrar!.instanceManager.addHostCreatedInstance(view) | ||
|
|
||
| // Attaches an associated object to the InstanceManager to listen for when it is deallocated. | ||
| var finalizer: TestFinalizer? = TestFinalizer() | ||
|
|
||
| let key = malloc(1)! | ||
| defer { | ||
| free(key) | ||
| } | ||
| objc_setAssociatedObject( | ||
| plugin.proxyApiRegistrar!.instanceManager, key, finalizer, .OBJC_ASSOCIATION_RETAIN) | ||
| let expectation = self.expectation(description: "Wait for InstanceManager to be deallocated.") | ||
| TestFinalizer.onDeinit = { | ||
| expectation.fulfill() | ||
| } | ||
|
|
||
| // Ensure method is from `FlutterApplicationLifeCycleDelegate`. | ||
| (plugin as FlutterApplicationLifeCycleDelegate).applicationWillTerminate!( | ||
| UIApplication.shared) | ||
| XCTAssertNil(plugin.proxyApiRegistrar) | ||
|
|
||
| finalizer = nil | ||
| waitForExpectations(timeout: 5.0) | ||
| } | ||
|
|
||
| func testInstanceManagerIsDeallocatedInSceneDidDisconnect() { | ||
| let plugin = WebViewFlutterPlugin(binaryMessenger: TestBinaryMessenger()) | ||
| plugin.proxyApiRegistrar!.setUp() | ||
|
|
||
| let view = UIView() | ||
| _ = plugin.proxyApiRegistrar!.instanceManager.addHostCreatedInstance(view) | ||
|
|
||
| // Attaches an associated object to the InstanceManager to listen for when it is deallocated. | ||
| var finalizer: TestFinalizer? = TestFinalizer() | ||
|
|
||
| let key = malloc(1)! | ||
| defer { | ||
| free(key) | ||
| } | ||
| objc_setAssociatedObject( | ||
| plugin.proxyApiRegistrar!.instanceManager, key, finalizer, .OBJC_ASSOCIATION_RETAIN) | ||
| let expectation = self.expectation(description: "Wait for InstanceManager to be deallocated.") | ||
| TestFinalizer.onDeinit = { | ||
| expectation.fulfill() | ||
| } | ||
|
|
||
| let scene = UIApplication.shared.connectedScenes.first! | ||
|
|
||
| // Ensure method is from `FlutterSceneLifeCycleDelegate`. | ||
| (plugin as FlutterSceneLifeCycleDelegate).sceneDidDisconnect?(scene) | ||
| XCTAssertNil(plugin.proxyApiRegistrar) | ||
|
|
||
| finalizer = nil | ||
| waitForExpectations(timeout: 5.0) | ||
| } | ||
| #endif | ||
| } | ||
|
|
||
| class TestFinalizer { | ||
| static var onDeinit: (() -> Void)? | ||
|
|
||
| deinit { | ||
| Self.onDeinit?() | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why application delegate rather than the newer scene delegate that replaces it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scene delegate doesn't completely replace application delegate. Only the callbacks related to UI State.
applicationWillTerminateis still called for the application delegate. I manually tested that this is called when the application is removed in the app switcher.I also added the
sceneDidDisconnectcallback to tear down the registrar. This should also be an indicator that the engine is being torn down and callbacks would cause an error.