[google_maps_flutter] Replace use of zIndex in examples and tests by stuartmorgan-g · Pull Request #11572 · flutter/packages

stuartmorgan-g · 2026-04-23T15:38:02Z

Replaces uses of the deprecated zIndex in examples and tests with the preferred zIndexInt.

This doesn't change the production use of zIndex in google_maps_flutter_web, as that could change behavior, so should stay for now.

Replaces uses of the deprecated `zIndex` in examples and tests with the preferred `zIndexInt`. This doesn't change the production use of `zIndex` in google_maps_flutter_web, as that could change behavior, so should stay for now.

gemini-code-assist

Code Review

This pull request replaces the deprecated double-based zIndex property with the integer-based zIndexInt across the Google Maps Flutter Android and iOS packages, including their respective examples and tests. The changes update marker creation, z-index modification logic, and test assertions to use the new integer property. Reviewer feedback suggests further consistency by updating parameter names and test expectation properties to fully utilize the zIndexInt API.

gemini-code-assist · 2026-04-23T15:40:25Z

    rotation: marker.rotation,
    visible: marker.visible,
-    zIndex: marker.zIndex.toInt(),
+    zIndex: marker.zIndexInt,


To fully migrate away from the deprecated zIndex parameter, consider using zIndexInt here as well, as it is the preferred parameter for AdvancedMarker.

Suggested change

zIndex: marker.zIndexInt,

zIndexInt: marker.zIndexInt,

gemini-code-assist · 2026-04-23T15:40:25Z

      expect(firstChanged.rotation, object2new.rotation);
      expect(firstChanged.visible, object2new.visible);
-      expect(firstChanged.zIndex, object2new.zIndex);
+      expect(firstChanged.zIndex, object2new.zIndexInt);


To fully migrate away from the deprecated zIndex property, consider using zIndexInt on the expected object as well, assuming it has been updated in the platform interface.

Suggested change

expect(firstChanged.zIndex, object2new.zIndexInt);

expect(firstChanged.zIndexInt, object2new.zIndexInt);

gemini-code-assist · 2026-04-23T15:40:25Z

      expect(firstAdded.rotation, object3.rotation);
      expect(firstAdded.visible, object3.visible);
-      expect(firstAdded.zIndex, object3.zIndex);
+      expect(firstAdded.zIndex, object3.zIndexInt);


To fully migrate away from the deprecated zIndex property, consider using zIndexInt on the expected object as well, assuming it has been updated in the platform interface.

Suggested change

expect(firstAdded.zIndex, object3.zIndexInt);

expect(firstAdded.zIndexInt, object3.zIndexInt);

gemini-code-assist · 2026-04-23T15:40:25Z

    rotation: marker.rotation,
    visible: marker.visible,
-    zIndex: marker.zIndex.toInt(),
+    zIndex: marker.zIndexInt,


To fully migrate away from the deprecated zIndex parameter, consider using zIndexInt here as well, as it is the preferred parameter for AdvancedMarker.

Suggested change

zIndex: marker.zIndexInt,

zIndexInt: marker.zIndexInt,

gemini-code-assist · 2026-04-23T15:40:25Z

      expect(firstChanged.rotation, object2new.rotation);
      expect(firstChanged.visible, object2new.visible);
-      expect(firstChanged.zIndex, object2new.zIndex);
+      expect(firstChanged.zIndex, object2new.zIndexInt);


To fully migrate away from the deprecated zIndex property, consider using zIndexInt on the expected object as well, assuming it has been updated in the platform interface.

Suggested change

expect(firstChanged.zIndex, object2new.zIndexInt);

expect(firstChanged.zIndexInt, object2new.zIndexInt);

gemini-code-assist · 2026-04-23T15:40:26Z

      expect(firstChanged.rotation, object2new.rotation);
      expect(firstChanged.visible, object2new.visible);
-      expect(firstChanged.zIndex, object2new.zIndex);
+      expect(firstChanged.zIndex, object2new.zIndexInt);


To fully migrate away from the deprecated zIndex property, consider using zIndexInt on the expected object as well, assuming it has been updated in the platform interface.

Suggested change

expect(firstChanged.zIndex, object2new.zIndexInt);

expect(firstChanged.zIndexInt, object2new.zIndexInt);

gemini-code-assist · 2026-04-23T15:40:26Z

      expect(firstAdded.rotation, object3.rotation);
      expect(firstAdded.visible, object3.visible);
-      expect(firstAdded.zIndex, object3.zIndex);
+      expect(firstAdded.zIndex, object3.zIndexInt);


To fully migrate away from the deprecated zIndex property, consider using zIndexInt on the expected object as well, assuming it has been updated in the platform interface.

Suggested change

expect(firstAdded.zIndex, object3.zIndexInt);

expect(firstAdded.zIndexInt, object3.zIndexInt);

gemini-code-assist · 2026-04-23T15:40:26Z

    rotation: marker.rotation,
    visible: marker.visible,
-    zIndex: marker.zIndex.toInt(),
+    zIndex: marker.zIndexInt,


To fully migrate away from the deprecated zIndex parameter, consider using zIndexInt here as well, as it is the preferred parameter for AdvancedMarker.

Suggested change

zIndex: marker.zIndexInt,

zIndexInt: marker.zIndexInt,

gemini-code-assist · 2026-04-23T15:40:26Z

      expect(firstChanged.rotation, object2new.rotation);
      expect(firstChanged.visible, object2new.visible);
-      expect(firstChanged.zIndex, object2new.zIndex);
+      expect(firstChanged.zIndex, object2new.zIndexInt);


To fully migrate away from the deprecated zIndex property, consider using zIndexInt on the expected object as well, assuming it has been updated in the platform interface.

Suggested change

expect(firstChanged.zIndex, object2new.zIndexInt);

expect(firstChanged.zIndexInt, object2new.zIndexInt);

gemini-code-assist · 2026-04-23T15:40:26Z

      expect(firstAdded.rotation, object3.rotation);
      expect(firstAdded.visible, object3.visible);
-      expect(firstAdded.zIndex, object3.zIndex);
+      expect(firstAdded.zIndex, object3.zIndexInt);


To fully migrate away from the deprecated zIndex property, consider using zIndexInt on the expected object as well, assuming it has been updated in the platform interface.

Suggested change

expect(firstAdded.zIndex, object3.zIndexInt);

expect(firstAdded.zIndexInt, object3.zIndexInt);

bparrishMines

LGTM

stuartmorgan-g requested review from bparrishMines and tarrinneal April 23, 2026 15:38

stuartmorgan-g added override: no changelog needed Override the check requiring CHANGELOG updates for most changes CICD Run CI/CD labels Apr 23, 2026

github-actions Bot added p: google_maps_flutter platform-android platform-ios labels Apr 23, 2026

gemini-code-assist Bot reviewed Apr 23, 2026

View reviewed changes

bparrishMines approved these changes Apr 29, 2026

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 29, 2026

auto-submit Bot merged commit 5653b5a into flutter:main Apr 29, 2026
83 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[google_maps_flutter] Replace use of zIndex in examples and tests#11572

[google_maps_flutter] Replace use of zIndex in examples and tests#11572
auto-submit[bot] merged 1 commit intoflutter:mainfrom
stuartmorgan-g:maps-zindex-deprecation

stuartmorgan-g commented Apr 23, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Uh oh!

bparrishMines left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	expect(firstChanged.zIndex, object2new.zIndexInt);
	expect(firstChanged.zIndexInt, object2new.zIndexInt);

	expect(firstAdded.zIndex, object3.zIndexInt);
	expect(firstAdded.zIndexInt, object3.zIndexInt);

Conversation

stuartmorgan-g commented Apr 23, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants