Skip to content

[ci] Adds ci enable branch for batch release#11614

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
chunhtai:update-ci-2
May 5, 2026
Merged

[ci] Adds ci enable branch for batch release#11614
auto-submit[bot] merged 3 commits into
flutter:mainfrom
chunhtai:update-ci-2

Conversation

@chunhtai
Copy link
Copy Markdown
Contributor

@chunhtai chunhtai commented Apr 29, 2026

as title

this is for the ci check in batch release pr https://github.com/flutter/packages/pull/11613/checks?check_run_id=73678550049

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Apr 29, 2026
@chunhtai chunhtai marked this pull request as ready for review April 30, 2026 16:47
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a validation check to the RepoPackageInfoCheckCommand to ensure that .ci.yaml contains the appropriate release branch patterns for batch and non-batch packages. It also includes unit tests to verify these checks under various conditions. Review feedback suggests improving the robustness and efficiency of the YAML parsing logic and correcting a minor formatting inconsistency in an error message.

Comment thread script/tool/lib/src/repo_package_info_check_command.dart Outdated
Comment thread script/tool/lib/src/repo_package_info_check_command.dart Outdated
@github-actions github-actions Bot removed the CICD Run CI/CD label Apr 30, 2026
@chunhtai chunhtai added the CICD Run CI/CD label Apr 30, 2026
@chunhtai chunhtai requested a review from stuartmorgan-g April 30, 2026 17:00
Copy link
Copy Markdown
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just landed a refactor that moved all of this logic into a file in lib/src/validators/, so you'll need to move it there, but that should be simple since it was a mostly-direct move.

Comment thread script/tool/lib/src/repo_package_info_check_command.dart Outdated
@github-actions github-actions Bot removed the CICD Run CI/CD label May 4, 2026
if (isBatchRelease) {
printError(
'${_indentation}Missing .ci.yaml file at the repository root.\n'
'${_indentation}See https://github.com/flutter/flutter/blob/master/docs/ecosystem/release/README.md#batch-release',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update this doc once everything is settled. This pr should be the last one hopefully

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 4, 2026
@chunhtai chunhtai requested a review from stuartmorgan-g May 4, 2026 17:41
Copy link
Copy Markdown
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label May 5, 2026
@auto-submit auto-submit Bot merged commit 0cb296f into flutter:main May 5, 2026
84 checks passed
pull Bot pushed a commit to ahamedjobayer081-spec/flutter that referenced this pull request May 6, 2026
…r#186145)

flutter/packages@1ef39dc...67ec0d3

2026-05-05 stuartmorgan@google.com [url_launcher] Remove obsolete
LICENSE entries (flutter/packages#11631)
2026-05-05 57368238+q2a3z@users.noreply.github.com [camera_android]
Reset AE and AF triggers to idle after capture (flutter/packages#11330)
2026-05-05 47866232+chunhtai@users.noreply.github.com [ci] Adds ci
enable branch for batch release (flutter/packages#11614)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants