[material_ui] Enable text_field_test#12022
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes skip annotations from bottom navigation bar and text field tests, reorganizes imports, and introduces shared test utilities including MockClipboard, FeedbackTester, and a centralized findByTooltip helper. Additionally, several text selection toolbar assertion helpers were added to the text field tests. The review feedback highlights a potential runtime type error when casting clipboard data, a potential null pointer exception in the tooltip finder, and a consistency issue where a newly added toolbar assertion helper should be made private.
be44a58 to
77bdbaf
Compare
There was a problem hiding this comment.
Code Review
This pull request re-enables the tests in text_field_test.dart by removing the @Skip annotation and resolving cross-import issues. It introduces a new MockClipboard helper class in clipboard_utils.dart and refactors text_field_test.dart to use private helper methods for toolbar assertions and wrap scroll animations in unawaited. Review feedback suggests refactoring clipboardData in MockClipboard to use Map<dynamic, dynamic>? instead of dynamic to avoid potential runtime type errors during platform channel map casting.
a1e95de to
83d220b
Compare
This reverts commit 214368a.
Port over
text_field_testfrom flutter/flutter#184279Work towards flutter/flutter#182636 and flutter/flutter#188395
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2