Skip to content

[material_ui] Enable text_field_test#12022

Open
elliette wants to merge 6 commits into
flutter:mainfrom
elliette:pr184297/text-field-test
Open

[material_ui] Enable text_field_test#12022
elliette wants to merge 6 commits into
flutter:mainfrom
elliette:pr184297/text-field-test

Conversation

@elliette

@elliette elliette commented Jun 25, 2026

Copy link
Copy Markdown
Member

Port over text_field_test from flutter/flutter#184279

Work towards flutter/flutter#182636 and flutter/flutter#188395

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 25, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes skip annotations from bottom navigation bar and text field tests, reorganizes imports, and introduces shared test utilities including MockClipboard, FeedbackTester, and a centralized findByTooltip helper. Additionally, several text selection toolbar assertion helpers were added to the text field tests. The review feedback highlights a potential runtime type error when casting clipboard data, a potential null pointer exception in the tooltip finder, and a consistency issue where a newly added toolbar assertion helper should be made private.

Comment thread packages/material_ui/test/clipboard_utils.dart
Comment thread packages/material_ui/test/finders.dart
Comment thread packages/material_ui/test/text_field_test.dart Outdated

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables the tests in text_field_test.dart by removing the @Skip annotation and resolving cross-import issues. It introduces a new MockClipboard helper class in clipboard_utils.dart and refactors text_field_test.dart to use private helper methods for toolbar assertions and wrap scroll animations in unawaited. Review feedback suggests refactoring clipboardData in MockClipboard to use Map<dynamic, dynamic>? instead of dynamic to avoid potential runtime type errors during platform channel map casting.

Comment thread packages/material_ui/test/clipboard_utils.dart
@elliette elliette force-pushed the pr184297/text-field-test branch from a1e95de to 83d220b Compare June 26, 2026 20:25
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 26, 2026
@elliette elliette added the CICD Run CI/CD label Jun 26, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 26, 2026
@elliette elliette added the CICD Run CI/CD label Jun 26, 2026
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 26, 2026
This reverts commit 214368a.
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant