[go_router] Fix ShellRoute documentation#2621
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Sep 26, 2022
Merged
Conversation
mono0926
commented
Sep 20, 2022
Contributor
Author
There was a problem hiding this comment.
Alternatively, the following may be okay.
/// final GlobalKey<NavigatorState> _rootNavigatorKey = GlobalKey<NavigatorState>();
loic-sharma
approved these changes
Sep 20, 2022
chunhtai
approved these changes
Sep 20, 2022
Contributor
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, thanks for catching it
Contributor
|
auto label is removed for flutter/packages, pr: 2621, due to - The status or check suite publishable has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Contributor
|
can you add an entry in ChangeLog.md with |
Contributor
Author
e08c501 to
8339c7a
Compare
Contributor
|
@mono0926 Ah the ci suggests publishing a new version, can you publish a new version instead of using the |
8339c7a to
fc62565
Compare
Contributor
Author
done 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the missing code examples in ShellRoute class - go_router library - Dart API.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.