Skip to content

[flutter_markdown] add padding for p, h1-h6#465

Merged
domesticmouse merged 13 commits intoflutter:masterfrom
ne-ray:flutter_markdown_p_h1_h6_padding
Oct 6, 2021
Merged

[flutter_markdown] add padding for p, h1-h6#465
domesticmouse merged 13 commits intoflutter:masterfrom
ne-ray:flutter_markdown_p_h1_h6_padding

Conversation

@ne-ray
Copy link
Contributor

@ne-ray ne-ray commented Sep 13, 2021

This PR add padding for p, h1-h6 text block

Markdown add padding for p, h1-h6

Pre-launch Checklist

  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla
Copy link

google-cla bot commented Sep 13, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ne-ray
Copy link
Contributor Author

ne-ray commented Sep 13, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 13, 2021
@ne-ray ne-ray marked this pull request as ready for review September 13, 2021 22:30
@ne-ray ne-ray changed the title [flutter_markdown] add padding for p, h1-h6 [flutter_markdown]: add padding for p, h1-h6 Sep 14, 2021
@ne-ray ne-ray changed the title [flutter_markdown]: add padding for p, h1-h6 [flutter_markdown] add padding for p, h1-h6 Sep 14, 2021
@domesticmouse
Copy link
Contributor

Thanks @ne-ray!

@domesticmouse domesticmouse merged commit 5929818 into flutter:master Oct 6, 2021
stuartmorgan-g pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants