[rfw] Apply review comments from Yegor#474
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Oct 1, 2021
Merged
Conversation
Contributor
Author
|
cc @yjbanov |
Hixie
force-pushed
the
rfw
branch
2 times, most recently
from
34c798f to
6a39749
Compare
This makes a variety of minor changes to improve the efficiency of the implementation and documentation quality.
yjbanov
approved these changes
Sep 29, 2021
| /// * `"`: represents U+0022 (") | ||
| /// * `'`: represents U+0027 (') | ||
| /// * `/`: represents U+002F (/) | ||
| /// * `\`: represents U+005C (\) |
Contributor
There was a problem hiding this comment.
Do these need to be prefixed by \? The grammar says <U+005C> symbol if I'm reading it correctly.
Contributor
Author
There was a problem hiding this comment.
not sure what you are asking, can you elaborate?
Contributor
There was a problem hiding this comment.
For example, instead of:
* `"`: represents U+0022 (")
^ no back slash
should it be:
* `\"`: represents U+0022 (")
^^ back slash
?
Contributor
Author
There was a problem hiding this comment.
oh i have no idea. let's find out. :-)
stuartmorgan-g
pushed a commit
that referenced
this pull request
Oct 31, 2024
Add a flag to treat unhandled elements as errors rather than warnings.
stuartmorgan-g
pushed a commit
that referenced
this pull request
Aug 27, 2025
Bumps [plugin_platform_interface](https://github.com/flutter/packages/tree/main/packages) from 2.1.5 to 2.1.6. - [Release notes](https://github.com/flutter/packages/releases) - [Commits](https://github.com/flutter/packages/commits/plugin_platform_interface-v2.1.6/packages) --- updated-dependencies: - dependency-name: plugin_platform_interface dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a variety of minor changes to improve the efficiency of the implementation and documentation quality.
Pre-launch Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy.CHANGELOG.mdto add a description of the change.///).If you need help, consider asking for advice on the
#hackers-newchannel on Discord.