[video_player] Implement caching - #2130
Conversation
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
70660e6 to
260edd8
Compare
260edd8 to
5f4f141
Compare
|
@lukepighetti can you sign the google cla please to be able to merge this? |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@999eagle did you end up getting eyes on the uri stuff on iOS to make sure it was setup appropriately? I kept having issues with certain URLs but I never was able to determine if that was a local issue or not. |
|
@999eagle Thank you for your solution. Could you update this branch due master updates please? |
|
@999eagle thank you for your contribution! Unfortunately the structure of the plugin has changed lately to support implementations on more platforms. Mainly the plugin was moved to a new subdirectory and now uses a common platform interface. Adapting your PR to the new structure should be straight forward. If you have questions please ask! Please also make sure to include tests for the new functionality. |
|
Hello @999eagle @cbenhagen @lukepighetti, @iskakaushik @cyanglaz. |
|
Hi Would like to ask when would this be merged? really want to have this feature |
|
What's blocking this from being merged? |
|
It appears this PR should be closed for being stale, and the tracking PR for this feature is located here: #2429 (comment) |
|
Closing in favor of #2429 |
Description
This PR adds a way to cache videos played from an Uri. Two new parameters (
maxCacheSizeandmaxFileSize) have been added to the platform method call and the Dart side has been changed to pass these parameters as well.Related Issues
Resolves flutter/flutter#28094.
Checklist
///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?