Continues removing the assumption that there is a foreground activity #309
Conversation
zanderso
force-pushed
the
no-activity
branch
3 times, most recently
from
5a3a346 to
56d76a2
Compare
| } | ||
|
|
||
| private final Context context; | ||
| private final PluginRegistry.Registrar mRegistrar; |
There was a problem hiding this comment.
The mMember naming convention is not used in the existing code. I think we should either keep the current coding style, or apply the m prefix to all members.
Here and elsewhere.
There was a problem hiding this comment.
Changed to match existing style in each file.
| final EventChannel eventChannel = | ||
| new EventChannel(registrar.messenger(), "plugins.flutter.io/charging"); | ||
| final BatteryPlugin instance = new BatteryPlugin(registrar.context()); | ||
| final BatteryPlugin instance = new BatteryPlugin(registrar); |
There was a problem hiding this comment.
AFAIK, registrar.context() constantly returns the same value. If that is correct, this change isn't strictly necessary. Are we doing it anyway for consistency with plugins that need the registrar to access the current Activity?
Same in other plugins that just need a Context, and not an Activity.
There was a problem hiding this comment.
Yes, it's for consistency.
|
|
||
| Activity activity = mRegistrar.activity(); | ||
| if (activity == null) { | ||
| result.error("NO_ACTIVITY", "image_picker plugin requires a foreground activity.", null); |
There was a problem hiding this comment.
You've used "no_activity" in all other places in this PR.
There was a problem hiding this comment.
Changed to no_activity here
zanderso
force-pushed
the
no-activity
branch
from
56d76a2 to
ce87583
Compare
zanderso
force-pushed
the
no-activity
branch
from
ce87583 to
79c24b7
Compare
3 participants
No description provided.