Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Dec 19, 2017

Copy link
Contributor

@mravn-google mravn-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

? new Center(
child: new AspectRatio(
aspectRatio:
controller.value.size.width / controller.value.size.height,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe extract controller.value or controller.value.size into a local variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sigurdm sigurdm merged commit 8337af1 into flutter:master Dec 19, 2017
@sigurdm sigurdm deleted the size branch December 19, 2017 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants