This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Change requestAgent to "flutter-alpha" #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
suggested changes
Jan 3, 2018
Contributor
collinjackson
left a comment
collinjackson
left a comment
There was a problem hiding this comment.
I think this change doesn't actually do what you want, because there's no default MobileAdTargetingInfo if the user doesn't specify one. We should have MobileAd use a default MobileAdTargetingInfo if there isn't one specified, and make sure to test this behavior.
collinjackson
approved these changes
Jan 3, 2018
| /// Default constructor, used by subclasses. | ||
| MobileAd({@required this.unitId, this.targetingInfo, this.listener}) { | ||
| MobileAd({@required this.unitId, MobileAdTargetingInfo targetingInfo, this.listener}) | ||
| : _targetingInfo = targetingInfo ?? const MobileAdTargetingInfo(); |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AdMob team advised us to not make the
requestAgenta public part of theMobileAdTargetingInfoclass but to set it to "flutter-version".