Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Expose VideoScrubber so it can be used to create custom video timelines #6680

merged 7 commits into from Jan 19, 2023


Copy link

@Rexios80 Rexios80 commented Nov 7, 2022

Exposes VideoScrubber so it can be used to create custom video timelines


Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Rexios80 Rexios80 changed the title Feature/expose video scrubber 2 [video_player] Expose VideoScrubber so it can be used to create custom video timelines Nov 7, 2022
Copy link

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@gaaclarke gaaclarke merged commit dc2e4a0 into flutter:main Jan 19, 2023
53 checks passed
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
…tom video timelines (flutter#6680)

* Expose `VideoScrubber` so it can be used to make custom video timelines

* Added documentation

* Updated version

* Cleanup

* Formatting

* Update
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
2 participants