Skip to content

fixed crash if you back out of 2 double engine activities #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2021
Merged

fixed crash if you back out of 2 double engine activities #763

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33a57d3
fixed crash if you back out of 2 double engine activities
gaaclarke Mar 9, 2021
7ede955
xiao feedback
gaaclarke Mar 9, 2021
498cece
removed unused variable
gaaclarke Mar 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions ..._flutters_android/app/src/main/java/dev/flutter/multipleflutters/DoubleFlutterActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ class DoubleFlutterActivity : FragmentActivity(), EngineBindingsDelegate {
EngineBindings(activity = this, delegate = this, entrypoint = "bottomMain")
}
private val numberOfFlutters = 2
private val engineCountStart : Int
private companion object {
var engineCounter = 0
}

init {
engineCountStart = engineCounter
engineCounter += numberOfFlutters
}

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
Expand All @@ -35,26 +44,26 @@ class DoubleFlutterActivity : FragmentActivity(), EngineBindingsDelegate {

setContentView(root)

val app = applicationContext as App

for (i in 0 until numberOfFlutters) {
val engineId = engineCountStart + i
val containerId = 12345 + engineId
val flutterContainer = FrameLayout(this)
root.addView(flutterContainer)
flutterContainer.id = 12345 + i
flutterContainer.id = containerId
flutterContainer.layoutParams = LinearLayout.LayoutParams(
FrameLayout.LayoutParams.MATCH_PARENT,
FrameLayout.LayoutParams.MATCH_PARENT,
1.0f
)
val engine = if (i == 0) topBindings.engine else bottomBindings.engine
FlutterEngineCache.getInstance().put(i.toString(), engine)
FlutterEngineCache.getInstance().put(engineId.toString(), engine)
val flutterFragment =
FlutterFragment.withCachedEngine(i.toString()).build<FlutterFragment>()
FlutterFragment.withCachedEngine(engineId.toString()).build<FlutterFragment>()
fragmentManager
.beginTransaction()
.add(
12345 + i,
flutterFragment
containerId,
flutterFragment
)
.commit()
}
Expand All @@ -65,7 +74,8 @@ class DoubleFlutterActivity : FragmentActivity(), EngineBindingsDelegate {

override fun onDestroy() {
for (i in 0 until numberOfFlutters) {
FlutterEngineCache.getInstance().remove(i.toString())
val engineId = engineCountStart + i
FlutterEngineCache.getInstance().remove(engineId.toString())
}

super.onDestroy()
Expand Down