lint: add --config CLI argument for custom config path#149
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a --config (or -c) option to the dart_skills_lint CLI, allowing users to specify a custom configuration file path. It updates the configuration loading logic to handle FileSystemException and other potential errors gracefully, and adds comprehensive integration tests to verify the new option's behavior. A review comment suggests improving the error logging for FileSystemException to avoid printing (null) if the file path is not available.
Comment on lines
+251
to
+253
| } on FileSystemException catch (e) { | ||
| _log.severe('Error: ${e.message} (${e.path})'); | ||
| return null; |
Contributor
There was a problem hiding this comment.
If e.path is null, printing (${e.path}) will output (null). It is safer to conditionally append the path only when it is non-null to keep the error message clean.
Suggested change
| } on FileSystemException catch (e) { | |
| _log.severe('Error: ${e.message} (${e.path})'); | |
| return null; | |
| } on FileSystemException catch (e) { | |
| final pathSuffix = e.path != null ? ' (${e.path})' : ''; | |
| _log.severe('Error: ${e.message}$pathSuffix'); | |
| return null; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
-c/--configCLI argument todart_skills_lintto support custom configuration file paths. Includes precedence logic ensuring--ignore-configoverrides--config, error handling for missing/malformed configuration files, and complete unit/integration tests.