Skip to content

Add trailing whitespace validator#77

Merged
reidbaker merged 6 commits intoflutter:mainfrom
reidbaker:r-add-trailing-whitespace-test
Apr 13, 2026
Merged

Add trailing whitespace validator#77
reidbaker merged 6 commits intoflutter:mainfrom
reidbaker:r-add-trailing-whitespace-test

Conversation

@reidbaker
Copy link
Copy Markdown
Contributor

  • Add rule for trailing whitespace
  • Update the skill for adding new validators

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the TrailingWhitespaceRule to the Dart skills linter, which identifies trailing whitespace in SKILL.md files while permitting exactly two spaces for Markdown hard line breaks. The PR also updates the project's documentation, including a new step-by-step guide for implementing rules, and enables the rule in the local configuration. Review feedback highlights the need to optimize RegExp instantiation for performance, improve pluralization in error messages, and resolve an inconsistency between the provided documentation and the existing rule registration architecture.

Comment thread tool/dart_skills_lint/lib/src/rules/trailing_whitespace_rule.dart Outdated
Comment thread tool/dart_skills_lint/lib/src/rules/trailing_whitespace_rule.dart Outdated
Comment thread tool/dart_skills_lint/.agents/skills/add-dart-lint-validation-rule/SKILL.md Outdated
@reidbaker reidbaker merged commit 777882c into flutter:main Apr 13, 2026
7 checks passed
@reidbaker reidbaker deleted the r-add-trailing-whitespace-test branch April 13, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant