Add /to/template link #12635
Add /to/template link #12635
Conversation
Summary of ChangesHello @loic-sharma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new redirect rule to enhance user convenience. It addresses the common issue of users forgetting the exact path for the design document template by ensuring that both Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Summary of ChangesHello @loic-sharma, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new redirect configuration within Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new redirect for /to/template to make it easier to find the design doc template. The change is straightforward and correctly placed. I've suggested a small improvement to use a relative path for the destination to avoid hardcoding the domain, which improves maintainability.
| { "source": "/to/state-management-sample", "destination": "/data-and-backend/state-mgmt/simple", "type": 301 }, | ||
| { "source": "/to/switch-flutter-version", "destination": "/install/upgrade#switch-to-a-specific-flutter-version", "type": 301 }, | ||
| { "source": "/to/team-infra", "destination": "https://github.com/flutter/flutter/blob/main/docs/triage/Infra-Triage.md", "type": 301 }, | ||
| { "source": "/to/template", "destination": "https://flutter.dev/go/template", "type": 301 }, |
There was a problem hiding this comment.
To avoid hardcoding the domain and for consistency with other internal redirects, it's better to use a relative path for the destination. This still achieves the desired daisy-chaining but is more maintainable.
| { "source": "/to/template", "destination": "https://flutter.dev/go/template", "type": 301 }, | |
| { "source": "/to/template", "destination": "/go/template", "type": 301 }, |
There was a problem hiding this comment.
Code Review
This pull request introduces a new redirect for /to/template to /go/template, providing an alternative short link for the design doc template. The change in firebase.json is straightforward, correct, and maintains the alphabetical order of the redirects. The use of daisy-chaining is consistent with existing patterns in the file and is a reasonable approach to ensure that /go/template remains the canonical source. I find no issues with this implementation.
|
Visit the preview URL for this PR (updated for commit e4fd088): https://flutter-docs-prod--pr12635-loic-sharma-patch-1-7ahd7k4a.web.app |
3 participants
I keep forgetting if the design doc template is flutter.dev/to/template or flutter.dev/go/template. This supports both through daisy chaining.