Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firebase.json
Original file line number Diff line number Diff line change
Expand Up @@ -827,6 +827,7 @@
{ "source": "/to/state-management-sample", "destination": "/data-and-backend/state-mgmt/simple", "type": 301 },
{ "source": "/to/switch-flutter-version", "destination": "/install/upgrade#switch-to-a-specific-flutter-version", "type": 301 },
{ "source": "/to/team-infra", "destination": "https://github.com/flutter/flutter/blob/main/docs/triage/Infra-Triage.md", "type": 301 },
{ "source": "/to/template", "destination": "https://flutter.dev/go/template", "type": 301 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To avoid hardcoding the domain and for consistency with other internal redirects, it's better to use a relative path for the destination. This still achieves the desired daisy-chaining but is more maintainable.

Suggested change
{ "source": "/to/template", "destination": "https://flutter.dev/go/template", "type": 301 },
{ "source": "/to/template", "destination": "/go/template", "type": 301 },

{ "source": "/to/test-drive", "destination": "/get-started/quick", "type": 301 },
{ "source": "/to/track-widget-creation", "destination": "/tools/devtools/inspector#track-widget-creation", "type": 301 },
{ "source": "/to/troubleshoot-devices", "destination": "/install/troubleshoot", "type": 301 },
Expand Down
Loading