Add onReorder callback migration guide#13012
Add onReorder callback migration guide#13012navaronbracke wants to merge 4 commits intoflutter:mainfrom
Conversation
Summary of ChangesHello @navaronbracke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive migration guide to assist developers in transitioning from the deprecated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a well-written and clear migration guide for the onReorder callback deprecation. The document effectively explains the background of the change, provides a step-by-step migration process, and includes helpful code examples for all affected widgets. This will be a great resource for developers. I have one minor suggestion to make the document slightly more concise.
src/content/release/breaking-changes/deprecate-onreorder-callback.md
Outdated
Show resolved
Hide resolved
dkwingsmt
left a comment
There was a problem hiding this comment.
Some minor suggestions. Take whichever you see fit. LGTM overall. Thank you!
src/content/release/breaking-changes/deprecate-onreorder-callback.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/deprecate-onreorder-callback.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/deprecate-onreorder-callback.md
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
Visit the preview URL for this PR (updated for commit 0fca5db): https://flutter-docs-prod--pr13012-deprecate-reorder-callback-1aevc57i.web.app |
f4caa77 to
c21593a
Compare
|
@dkwingsmt I adjusted the migration guide based on your feedback and made some other fixes as well.
@parlough Can we rerun the docs page again? I'd like to verify if my new formatting changes are good. |
src/content/release/breaking-changes/deprecate-onreorder-callback.md
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
Just making sure that everything still builds: |
Description of what this PR is changing or adding, and why:
This PR adds a migration guide for PR flutter/flutter#178242 since that change is not supported by
dart fix.Issues fixed by this PR (if any):
Related to flutter/flutter#127901
Related to flutter/flutter#169878
PRs or commits this PR depends on (if any):
flutter/flutter#178242