Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new cookbook recipe for displaying Cupertino sheets in Flutter, including a sample application, project configuration, and documentation. The review feedback suggests adopting arrow syntax for single-line functions to align with Effective Dart guidelines and removing the unnecessary Material Design flag from the pubspec file to optimize the Cupertino-specific example.
Collaborator
|
Visit the preview URL for this PR (updated for commit 6a4bf04): https://flutter-docs-prod--pr13223-issue-11598-cupertino-sheet-k56xzcol.web.app |
dkwingsmt
reviewed
Mar 26, 2026
Contributor
dkwingsmt
left a comment
There was a problem hiding this comment.
Overall LGTM except for one comment. Thank you!
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
conooi
approved these changes
Mar 26, 2026
sfshaza2
added a commit
that referenced
this pull request
Mar 26, 2026
Fixes #11598 Note to reviewers: Do we still need/want this? --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11598
Note to reviewers: Do we still need/want this?