Update built-in Kotlin migration doc#13254
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the breaking changes documentation by replacing the Android Gradle Plugin 9.0.0 migration guide with a more comprehensive guide focused on migrating Flutter Android projects to built-in Kotlin. The new documentation provides detailed instructions for apps, plugins, and host apps using both Kotlin and Groovy DSLs. Review feedback focuses on improving the documentation's adherence to technical writing standards, including the correct capitalization of "Flutter" and "Android," fixing grammatical errors in pluralization, and removing first-person pronouns and informal phrasing to align with style guidelines.
src/content/release/breaking-changes/migrate-to-built-in-kotlin.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin.md
Outdated
Show resolved
Hide resolved
|
Visit the preview URL for this PR (updated for commit 58d6ed8): https://flutter-docs-prod--pr13254-update-built-in-kotlin-migr-k8k1lhh5.web.app |
There was a problem hiding this comment.
Code Review
This pull request replaces the previous Android Gradle Plugin 9.0.0 migration guide with a comprehensive set of documents for migrating Flutter projects to built-in Kotlin. The new documentation includes dedicated guides for app developers and plugin authors, along with updated site navigation. Feedback identifies a missing link definition for Issue #184839 and suggests several improvements to the clarity of DSL block descriptions and the directness of internal links.
src/content/release/breaking-changes/migrate-to-built-in-kotlin/index.md
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-app-developers.md
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-app-developers.md
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-app-developers.md
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-plugin-authors.md
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-plugin-authors.md
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-plugin-authors.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-plugin-authors.md
Outdated
Show resolved
Hide resolved
sfshaza2
left a comment
There was a problem hiding this comment.
Overall, lgtm! Just a few formatting issues.
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-plugin-authors.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-plugin-authors.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-plugin-authors.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-plugin-authors.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/for-plugin-authors.md
Outdated
Show resolved
Hide resolved
src/content/release/breaking-changes/migrate-to-built-in-kotlin/index.md
Outdated
Show resolved
Hide resolved
…n/for-plugin-authors.md
…n/for-plugin-authors.md
…n/for-plugin-authors.md
…n/for-plugin-authors.md
…n/for-plugin-authors.md
…swrd/website into update-built-in-kotlin-migration-doc
Updated the name of doc from "Upgrade to AGP 9 Migration Docs" to "Built-in Kotlin Migraction Docs."
I added the following:
-migration instructions for plugin authors
-migration isntructions for app develoeprs working on add-to-app host apps
I also refactored the docs to have the same structure as the swift package manager migration docs here. They seem more readable.
These website docs links here are referenced when developers receive error logs here.
Related to: flutter/flutter#181557
Presubmit checklist
of 80 characters or fewer.