Skip to content

Highlight relevant lines per step in listenable-builder lesson#13291

Merged
sfshaza2 merged 1 commit intomainfrom
fix/13119
Apr 20, 2026
Merged

Highlight relevant lines per step in listenable-builder lesson#13291
sfshaza2 merged 1 commit intomainfrom
fix/13119

Conversation

@parlough
Copy link
Copy Markdown
Member

Fixes #13119 by more clearly separating the steps and the relevant content in each

@parlough parlough requested review from a team and sfshaza2 as code owners April 19, 2026 15:13
@parlough parlough requested a review from lamek April 19, 2026 15:13
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the listenable-builder.md tutorial by refining terminology and adding syntax highlighting to several code snippets to improve clarity. A review comment points out that instantiating a ChangeNotifier within a StatelessWidget is non-idiomatic in Flutter as it can lead to state loss when the widget is recreated, and suggests adding a note to clarify this simplification for the tutorial.

Comment thread src/content/learn/pathway/tutorial/listenable-builder.md
@flutter-website-bot
Copy link
Copy Markdown
Collaborator

Visit the preview URL for this PR (updated for commit d401b44):

https://flutter-docs-prod--pr13291-fix-13119-fcx5iobq.web.app

Copy link
Copy Markdown
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@sfshaza2 sfshaza2 merged commit 7c873e7 into main Apr 20, 2026
10 checks passed
@sfshaza2 sfshaza2 deleted the fix/13119 branch April 20, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Two time same page on Getting started courses

3 participants