Customize ports used by Jaspr during serving#13389
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements dynamic port assignment for the jaspr serve command, allowing multiple sites to be served concurrently by calculating ports based on the site's index. Feedback suggests that using the enum index for port calculation is unstable and could lead to collisions; it is recommended to define these ports explicitly in the Site constructor for better stability and clarity.
Collaborator
|
Visit the preview URL for this PR (updated for commit 016ccae): https://flutter-docs-prod--pr13389-misc-jaspr-port-customizati-hydvppjz.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps avoid conflicting with any other Jaspr sites you might happen to have running and additionally enables you to serve multiple of our own sites at the same time :D
Contributes to #13148